Skip to content

use posix error messages under 127 #6420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Dec 13, 2025
Merged

use posix error messages under 127 #6420

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61895e3
use posix error messages under 127
youknowone Dec 12, 2025
44e1e4d
use posix error message for unix
youknowone Dec 12, 2025
786a65e
unmark successful tests
youknowone Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
use posix error messages under 127
  • Loading branch information
@youknowone
youknowone committed Dec 12, 2025
commit 61895e3cba5bd7bb9436de7c8ee180f004bc24cf
22 changes: 21 additions & 1 deletion crates/vm/src/stdlib/io.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,30 @@ pub use _io::{OpenArgs, io_open as open};
impl ToPyException for std::io::Error {
fn to_pyexception(&self, vm: &VirtualMachine) -> PyBaseExceptionRef {
let errno = self.posix_errno();
#[cfg(windows)]
let msg = 'msg: {
// On Windows, use C runtime's strerror for POSIX errno values
// For Windows-specific error codes, fall back to FormatMessage

// UCRT's strerror returns "Unknown error" for invalid errno values
// Windows UCRT defines errno values 1-42 plus some more up to ~127
const MAX_POSIX_ERRNO: i32 = 127;
if errno > 0 && errno <= MAX_POSIX_ERRNO {
let ptr = unsafe { libc::strerror(errno) };
if !ptr.is_null() {
let s = unsafe { std::ffi::CStr::from_ptr(ptr) }.to_string_lossy();
if !s.starts_with("Unknown error") {
break 'msg s.into_owned();
}
}
}
self.to_string()
};
#[cfg(not(windows))]
let msg = self.to_string();

#[allow(clippy::let_and_return)]
let exc = vm.new_errno_error(errno, msg);

#[cfg(windows)]
{
use crate::object::AsObject;
Expand Down