Skip to content

windows umask, win32_xstat_slow_impl, fake EXT_SUFFIX #6340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 4 commits into from
Dec 8, 2025
Merged

windows umask, win32_xstat_slow_impl, fake EXT_SUFFIX #6340

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec50973
umask
youknowone Dec 6, 2025
8623b75
EXT_SUFFIX
youknowone Dec 6, 2025
159c978
File Attributes and win32_xstat_slow_impl
youknowone Dec 6, 2025
8317e6d
unmark tests
youknowone Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
unmark tests
  • Loading branch information
@youknowone
youknowone committed Dec 8, 2025
commit 8317e6d8b698e3288f1cf8deef9ad1fe2e108f35
7 changes: 0 additions & 7 deletions Lib/test/test_genericpath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,13 +352,6 @@ def test_invalid_paths(self):
with self.assertRaisesRegex(ValueError, 'embedded null'):
func(b'/tmp\x00abcds')

@unittest.expectedFailureIfWindows('TODO: RUSTPYTHON')
def test_samestat_on_symlink(self):
return super().test_samestat_on_symlink()

@unittest.expectedFailureIfWindows('TODO: RUSTPYTHON')
def test_samefile_on_symlink(self):
return super().test_samefile_on_symlink()

# Following TestCase is not supposed to be run from test_genericpath.
# It is inherited by other test modules (ntpath, posixpath).
Expand Down
1 change: 0 additions & 1 deletion Lib/test/test_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6384,7 +6384,6 @@ def rotator(source, dest):
rh.close()

class TimedRotatingFileHandlerTest(BaseFileTest):
@unittest.expectedFailureIfWindows('TODO: RUSTPYTHON')
@unittest.skipIf(support.is_wasi, "WASI does not have /dev/null.")
def test_should_not_rollover(self):
# See bpo-45401. Should only ever rollover regular files
Expand Down
10 changes: 0 additions & 10 deletions Lib/test/test_ntpath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1458,8 +1458,6 @@ def test_isfile_named_pipe(self):
finally:
_winapi.CloseHandle(h)

# TODO: RUSTPYTHON
@unittest.expectedFailure
@unittest.skipIf(sys.platform != 'win32', "windows only")
def test_con_device(self):
self.assertFalse(os.path.isfile(r"\\.\CON"))
Expand Down Expand Up @@ -1527,14 +1525,6 @@ def test_expandvars(self):
def test_expandvars_nonascii(self):
return super().test_expandvars_nonascii()

@unittest.expectedFailureIfWindows('TODO: RUSTPYTHON')
def test_samefile_on_symlink(self):
return super().test_samefile_on_symlink()

@unittest.expectedFailureIfWindows('TODO: RUSTPYTHON')
def test_samestat_on_symlink(self):
return super().test_samestat_on_symlink()


class PathLikeTests(NtpathTestCase):

Expand Down
6 changes: 0 additions & 6 deletions Lib/test/test_shutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1476,7 +1476,6 @@ def test_dont_copy_file_onto_link_to_itself(self):
finally:
shutil.rmtree(TESTFN, ignore_errors=True)

@unittest.expectedFailureIfWindows('TODO: RUSTPYTHON; AssertionError: SameFileError not raised for copyfile')
@os_helper.skip_unless_symlink
def test_dont_copy_file_onto_symlink_to_itself(self):
# bug 851123.
Expand Down Expand Up @@ -2577,7 +2576,6 @@ def test_destinsrc_false_positive(self):
finally:
os_helper.rmtree(TESTFN)

@unittest.expectedFailureIfWindows("TODO: RUSTPYTHON")
@os_helper.skip_unless_symlink
@mock_rename
def test_move_file_symlink(self):
Expand All @@ -2587,7 +2585,6 @@ def test_move_file_symlink(self):
self.assertTrue(os.path.islink(self.dst_file))
self.assertTrue(os.path.samefile(self.src_file, self.dst_file))

@unittest.expectedFailureIfWindows("TODO: RUSTPYTHON")
@os_helper.skip_unless_symlink
@mock_rename
def test_move_file_symlink_to_dir(self):
Expand All @@ -2611,7 +2608,6 @@ def test_move_dangling_symlink(self):
self.assertTrue(os.path.islink(dst_link))
self.assertEqual(os.path.realpath(src), os.path.realpath(dst_link))

@unittest.expectedFailureIfWindows("TODO: RUSTPYTHON")
@os_helper.skip_unless_symlink
@mock_rename
def test_move_dir_symlink(self):
Expand Down Expand Up @@ -2687,12 +2683,10 @@ def _test_move_symlink_to_dir_into_dir(self, dst):
self.assertTrue(os.path.samefile(self.dst_dir, dst_link))
self.assertTrue(os.path.exists(src))

@unittest.expectedFailureIfWindows("TODO: RUSTPYTHON")
@os_helper.skip_unless_symlink
def test_move_symlink_to_dir_into_dir(self):
self._test_move_symlink_to_dir_into_dir(self.dst_dir)

@unittest.expectedFailureIfWindows("TODO: RUSTPYTHON")
@os_helper.skip_unless_symlink
def test_move_symlink_to_dir_into_symlink_to_dir(self):
dst = os.path.join(self.src_dir, 'otherlinktodir')
Expand Down
Loading