Skip to content

Auto-format before checks #6275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShaharNaveh wants to merge 5 commits into from
Closed

Auto-format before checks #6275

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df498ad
Add auto-format before checks
ShaharNaveh Nov 15, 2025
65549b2
Fix
ShaharNaveh Nov 15, 2025
7b52ebc
Trigger CI
ShaharNaveh Nov 15, 2025
49c41c9
Merge remote-tracking branch 'upstream/main' into auto-format-before-…
ShaharNaveh Nov 15, 2025
a577106
malformat
youknowone Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Nov 15, 2025
commit 65549b24e9a50e4a2d4bed34716497d607fa47b3
8 changes: 5 additions & 3 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ jobs:
continue-on-error: true # Will fail if nothing to commit

- name: Comment on PR
if: ${{ steps.git_commit.outcome == 'success' }}
if: ${{ steps.git-commit.outcome == 'success' }}
uses: marocchino/sticky-pull-request-comment@v2
with:
number: ${{ github.event.pull_request.number }}
Expand All @@ -164,14 +164,16 @@ jobs:
**Run**: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}

- name: git push
run: git push origin HEAD:${{ github.event.pull_request.head.ref }}
run: git push origin HEAD:${{ env.HEAD_REF }}
env:
HEAD_REF: ${{ github.event.pull_request.head.ref }}
if: steps.git-commit.outcome == 'success'

# This step is not really needed as the earlier push should cancel this run anyways.
# But we are making sure that we abort if we had badly formatted files.
- name: Exit if changed
run: exit 1
if: ${{ steps.git_commit.outcome == 'success' }}
if: ${{ steps.git-commit.outcome == 'success' }}

rust_tests:
if: ${{ !cancelled() && !contains(github.event.pull_request.labels.*.name, 'skip:ci') }}
Expand Down
Loading