Skip to content

Implement minimal builtins.anext() #6226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Oct 29, 2025
Merged

Implement minimal builtins.anext() #6226

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d08b04e
Implement minimal builtins.anext()
YashSuthar983 Oct 28, 2025
a393845
Removed expectedFailure for builtins.anext() tests
YashSuthar983 Oct 29, 2025
82aae89
Removed expectedFailure from test_contextlib_async tests fixed by anext
YashSuthar983 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Removed expectedFailure from test_contextlib_async tests fixed by anext 
Signed-off-by: Yash Suthar <[email protected]>
  • Loading branch information
@YashSuthar983
YashSuthar983 committed Oct 29, 2025
commit 82aae89f05331b0172f3add609694eada62afbae
32 changes: 0 additions & 32 deletions Lib/test/test_contextlib_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ async def __aexit__(self, *args):
manager = DefaultAsyncContextManager()
manager.var = 42

# TODO: RUSTPYTHON
@unittest.expectedFailure
async def test_async_gen_propagates_generator_exit(self):
# A regression test for https://bugs.python.org/issue33786.

Expand Down Expand Up @@ -94,8 +92,6 @@ class NoneAexit(ManagerFromScratch):

class AsyncContextManagerTestCase(unittest.IsolatedAsyncioTestCase):

# TODO: RUSTPYTHON
@unittest.expectedFailure
async def test_contextmanager_plain(self):
state = []
@asynccontextmanager
Expand All @@ -109,8 +105,6 @@ async def woohoo():
state.append(x)
self.assertEqual(state, [1, 42, 999])

# TODO: RUSTPYTHON
@unittest.expectedFailure
async def test_contextmanager_finally(self):
state = []
@asynccontextmanager
Expand Down Expand Up @@ -185,8 +179,6 @@ class StopAsyncIterationSubclass(StopAsyncIteration):
self.assertEqual(frames[0].name, 'test_contextmanager_traceback')
self.assertEqual(frames[0].line, 'raise stop_exc')

# TODO: RUSTPYTHON
@unittest.expectedFailure
async def test_contextmanager_no_reraise(self):
@asynccontextmanager
async def whee():
Expand All @@ -196,8 +188,6 @@ async def whee():
# Calling __aexit__ should not result in an exception
self.assertFalse(await ctx.__aexit__(TypeError, TypeError("foo"), None))

# TODO: RUSTPYTHON
@unittest.expectedFailure
async def test_contextmanager_trap_yield_after_throw(self):
@asynccontextmanager
async def whoo():
Expand All @@ -213,8 +203,6 @@ async def whoo():
# The "gen" attribute is an implementation detail.
self.assertFalse(ctx.gen.ag_suspended)

# TODO: RUSTPYTHON
@unittest.expectedFailure
async def test_contextmanager_trap_no_yield(self):
@asynccontextmanager
async def whoo():
Expand All @@ -224,8 +212,6 @@ async def whoo():
with self.assertRaises(RuntimeError):
await ctx.__aenter__()

# TODO: RUSTPYTHON
@unittest.expectedFailure
async def test_contextmanager_trap_second_yield(self):
@asynccontextmanager
async def whoo():
Expand All @@ -239,8 +225,6 @@ async def whoo():
# The "gen" attribute is an implementation detail.
self.assertFalse(ctx.gen.ag_suspended)

# TODO: RUSTPYTHON
@unittest.expectedFailure
async def test_contextmanager_non_normalised(self):
@asynccontextmanager
async def whoo():
Expand All @@ -254,8 +238,6 @@ async def whoo():
with self.assertRaises(SyntaxError):
await ctx.__aexit__(RuntimeError, None, None)

# TODO: RUSTPYTHON
@unittest.expectedFailure
async def test_contextmanager_except(self):
state = []
@asynccontextmanager
Expand Down Expand Up @@ -301,8 +283,6 @@ class StopAsyncIterationSubclass(StopAsyncIteration):
else:
self.fail(f'{stop_exc} was suppressed')

# TODO: RUSTPYTHON
@unittest.expectedFailure
async def test_contextmanager_wrap_runtimeerror(self):
@asynccontextmanager
async def woohoo():
Expand Down Expand Up @@ -346,17 +326,13 @@ def test_contextmanager_doc_attrib(self):
baz = self._create_contextmanager_attribs()
self.assertEqual(baz.__doc__, "Whee!")

# TODO: RUSTPYTHON
@unittest.expectedFailure
@support.requires_docstrings
async def test_instance_docstring_given_cm_docstring(self):
baz = self._create_contextmanager_attribs()(None)
self.assertEqual(baz.__doc__, "Whee!")
async with baz:
pass # suppress warning

# TODO: RUSTPYTHON
@unittest.expectedFailure
async def test_keywords(self):
# Ensure no keyword arguments are inhibited
@asynccontextmanager
Expand All @@ -365,8 +341,6 @@ async def woohoo(self, func, args, kwds):
async with woohoo(self=11, func=22, args=33, kwds=44) as target:
self.assertEqual(target, (11, 22, 33, 44))

# TODO: RUSTPYTHON
@unittest.expectedFailure
async def test_recursive(self):
depth = 0
ncols = 0
Expand All @@ -393,8 +367,6 @@ async def recursive():
self.assertEqual(ncols, 10)
self.assertEqual(depth, 0)

# TODO: RUSTPYTHON
@unittest.expectedFailure
async def test_decorator(self):
entered = False

Expand All @@ -413,8 +385,6 @@ async def test():
await test()
self.assertFalse(entered)

# TODO: RUSTPYTHON
@unittest.expectedFailure
async def test_decorator_with_exception(self):
entered = False

Expand All @@ -437,8 +407,6 @@ async def test():
await test()
self.assertFalse(entered)

# TODO: RUSTPYTHON
@unittest.expectedFailure
async def test_decorating_method(self):

@asynccontextmanager
Expand Down
Loading