-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Enable PIP test on windows #6211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughA conditional guard preventing the ensurepip validation step from running on Windows is removed from the CI workflow, allowing the step to execute on all platforms. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
updated ensurepip but still not able to install pip |
|
3670fde to
6010499
Compare
6010499 to
f46a151
Compare
f46a151 to
ccffecd
Compare
|
Okay, finally it is working. It is (probably) our first PIP running on windows. The changed wheel includes 2 patches: |
fix #5681
fix #2671
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.