Skip to content

Fix CI #6196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Oct 20, 2025
Merged

Fix CI #6196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
220d39c
Update `vcpkg` to 2025.09.17
ShaharNaveh Oct 19, 2025
bc778ec
Pin selenium version
ShaharNaveh Oct 19, 2025
ef4f4c0
Use `localhost` instead of `0.0.0.0`
ShaharNaveh Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ lto = "thin"
git = "https://github.com/microsoft/vcpkg"
# The revision of the vcpkg repository to use
# https://github.com/microsoft/vcpkg/tags
rev = "2024.02.14"
rev = "2025.09.17"

[package.metadata.vcpkg.target]
x86_64-pc-windows-msvc = { triplet = "x64-windows-static-md", dev-dependencies = ["openssl" ] }
Expand Down
4 changes: 2 additions & 2 deletions wasm/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def pytest_sessionfinish(session):


# From https://gist.github.com/butla/2d9a4c0f35ea47b7452156c96a4e7b12
def wait_for_port(port, host="0.0.0.0", timeout=5.0):
def wait_for_port(port, host="localhost", timeout=5.0):
"""Wait until a port starts accepting TCP connections.
Args:
port (int): Port number.
Expand Down Expand Up @@ -94,7 +94,7 @@ def wdriver(request):
options.add_argument("-headless")
driver = Driver(options=options)
try:
driver.get(f"http://0.0.0.0:{PORT}")
driver.get(f"http://localhost:{PORT}")
WebDriverWait(driver, 5).until(
EC.presence_of_element_located((By.ID, "rp_loaded"))
)
Expand Down
2 changes: 1 addition & 1 deletion wasm/tests/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
pytest
selenium
selenium==4.36.0
certifi
Loading