-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Configure dependabot to ignore ruff updates #6185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ fn parse_inner(literal: &[u8]) -> Option<f64> { | |
| // lexical-core's format::PYTHON_STRING is inaccurate | ||
| const PYTHON_STRING: u128 = NumberFormatBuilder::rebuild(PYTHON3_LITERAL) | ||
| .no_special(false) | ||
| .build(); | ||
| .build_unchecked(); | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Comment on lines
19
to
+21
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chainJustify the use of The change from Possible reasons for this change:
Please verify:
Consider adding a comment explaining why 🏁 Script executed: #!/bin/bash
# Check if build() method exists and is const-compatible in lexical-parse-float 1.0.6
# Search for NumberFormatBuilder documentation or usage examples
rg -n -C3 'NumberFormatBuilder.*build\(' --type rustLength of output: 512 🌐 Web query: 💡 Result: You can use the const build() method — NumberFormatBuilder::build is a const fn, so you do not need build_unchecked() for const contexts. [1][2] Sources:
Replace File: compiler/literal/src/float.rs:21 🤖 Prompt for AI Agents |
||
| f64::from_lexical_with_options::<PYTHON_STRING>(literal, &Options::new()).ok() | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify the dependency version and check for security advisories.
Ensure that version
1.0.6oflexical-parse-floatexists and is free from known vulnerabilities.🏁 Script executed:
Length of output: 477
🌐 Web query:
💡 Result:
The latest version is 1.0.5 (published Jan 10, 2025). [1][2]
Sources:
Use the published crate version (v1.0.5)
In compiler/literal/Cargo.toml (line 16), change
to
(1.0.6 is not published on crates.io)
🤖 Prompt for AI Agents