Skip to content

Fix broken CI on windows #6143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 8 commits into from
Sep 11, 2025
Merged

Fix broken CI on windows #6143

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
201f0ea
Fix `test_dtrace.py`
ShaharNaveh Sep 10, 2025
bc2a01a
Fix `test_genericpath.py`
ShaharNaveh Sep 10, 2025
e33801a
fix `test_ntpath.py`
ShaharNaveh Sep 10, 2025
42edfdd
Fix `test_py_compile.py`
ShaharNaveh Sep 10, 2025
5b161af
Fix `test_shutil.py`
ShaharNaveh Sep 10, 2025
ef90c55
fix `test_stat.py`
ShaharNaveh Sep 10, 2025
912f340
Fix `test_tarfile.py`
ShaharNaveh Sep 10, 2025
0a55461
Mark failing tests
ShaharNaveh Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test_shutil.py
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Sep 10, 2025
commit 5b161afc4ed1447913cce7bbaac8fd2675fd675c
7 changes: 1 addition & 6 deletions Lib/test/test_shutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ def test_rmtree_works_on_bytes(self):
self.assertIsInstance(victim, bytes)
shutil.rmtree(victim)

@unittest.expectedFailureIfWindows("TODO: RUSTPYTHON")
@os_helper.skip_unless_symlink
def test_rmtree_fails_on_symlink_onerror(self):
tmp = self.mkdtemp()
Expand All @@ -216,7 +215,6 @@ def onerror(*args):
self.assertEqual(errors[0][1], link)
self.assertIsInstance(errors[0][2][1], OSError)

@unittest.expectedFailureIfWindows("TODO: RUSTPYTHON")
@os_helper.skip_unless_symlink
def test_rmtree_fails_on_symlink_onexc(self):
tmp = self.mkdtemp()
Expand Down Expand Up @@ -1087,7 +1085,6 @@ def test_copymode_follow_symlinks(self):
shutil.copymode(src_link, dst_link)
self.assertEqual(os.stat(src).st_mode, os.stat(dst).st_mode)

@unittest.expectedFailureIfWindows("TODO: RUSTPYTHON")
@unittest.skipUnless(hasattr(os, 'lchmod') or os.name == 'nt', 'requires os.lchmod')
@os_helper.skip_unless_symlink
def test_copymode_symlink_to_symlink(self):
Expand Down Expand Up @@ -1317,7 +1314,6 @@ def test_copy(self):
self.assertTrue(os.path.exists(file2))
self.assertEqual(os.stat(file1).st_mode, os.stat(file2).st_mode)

@unittest.expectedFailureIfWindows("TODO: RUSTPYTHON")
@os_helper.skip_unless_symlink
def test_copy_symlinks(self):
tmp_dir = self.mkdtemp()
Expand Down Expand Up @@ -1360,7 +1356,6 @@ def test_copy2(self):
self.assertEqual(getattr(file1_stat, 'st_flags'),
getattr(file2_stat, 'st_flags'))

@unittest.expectedFailureIfWindows("TODO: RUSTPYTHON")
@os_helper.skip_unless_symlink
def test_copy2_symlinks(self):
tmp_dir = self.mkdtemp()
Expand Down Expand Up @@ -1445,7 +1440,6 @@ def _test_copy_dir(self, copy_func):

### shutil.copyfile

@unittest.expectedFailureIfWindows("TODO: RUSTPYTHON")
@os_helper.skip_unless_symlink
def test_copyfile_symlinks(self):
tmp_dir = self.mkdtemp()
Expand Down Expand Up @@ -1483,6 +1477,7 @@ def test_dont_copy_file_onto_link_to_itself(self):
finally:
shutil.rmtree(TESTFN, ignore_errors=True)

@unittest.expectedFailureIfWindows('TODO: RUSTPYTHON')
@os_helper.skip_unless_symlink
def test_dont_copy_file_onto_symlink_to_itself(self):
# bug 851123.
Expand Down