Skip to content

Use ruff for Expr unparsing #6124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 9 commits into from
Oct 22, 2025
Merged

Use ruff for Expr unparsing #6124

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
38a7316
Use ruff for unparse backend
ShaharNaveh Sep 3, 2025
1ec2b91
Update `test_future_stmt/*.py` from 3.13.7
ShaharNaveh Sep 3, 2025
87dd525
Mark failing tests
ShaharNaveh Sep 3, 2025
1059814
Mark failing test
ShaharNaveh Sep 3, 2025
7baf20f
Merge remote-tracking branch 'upstream/main' into ruff-unparse
ShaharNaveh Oct 22, 2025
e92c3d4
Reapply ruff code
ShaharNaveh Oct 22, 2025
56f9f69
Merge remote-tracking branch 'upstream/main' into ruff-unparse
ShaharNaveh Oct 22, 2025
4b80a5d
remove git symbols
ShaharNaveh Oct 22, 2025
d963b31
Unmark passing test
ShaharNaveh Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mark failing test
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Sep 3, 2025
commit 105981444c4ae15c6340cbd16995cadcc65e18d6
1 change: 1 addition & 0 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4952,6 +4952,7 @@ def barfoo(x: AT): ...
def barfoo2(x: CT): ...
self.assertIs(get_type_hints(barfoo2, globals(), locals())['x'], CT)

@unittest.expectedFailure # TODO: RUSTPYTHON; 'List[list["C2"]]' != "List[list['C2']]"
Copy link
Member

@youknowone youknowone Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any option to change the quote style?

Copy link
Collaborator Author

@ShaharNaveh ShaharNaveh Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No:/ not from the Generator directly, I think that this needs to be fixed upstream (over Ruff's side)

Copy link
Member

@youknowone youknowone Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once Ruff forked rustpython-parser, we patched unparse to decide quote by option. That might be removed during refactoring. I have no idea if Ruff maintainers are interested in adding feature only for downstream user. Probably asking if possible be worth. Otherwise fork? but in easier form to sync.

Copy link
Collaborator Author

@ShaharNaveh ShaharNaveh Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@youknowone It will supported in the next ruff release.
astral-sh/ruff#20434

Copy link
Member

@youknowone youknowone Sep 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you so much!

def test_generic_pep585_forward_ref(self):
# See https://bugs.python.org/issue41370

Expand Down
Loading