Skip to content

wasm_js rustlfags on top workspace #6116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Sep 17, 2025
Merged

wasm_js rustlfags on top workspace #6116

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e14ba8
getrandom/wasm_js for rustpython-common
youknowone Aug 31, 2025
5cbb152
wasm_js rustflags on top workspace
youknowone Aug 31, 2025
2e36ff8
rustpython-common/wasm_js
youknowone Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
getrandom/wasm_js for rustpython-common
  • Loading branch information
@youknowone
youknowone committed Sep 14, 2025
commit 2e14ba865c7e2d3b22aff6bc1a4d75dd94d55cf4
3 changes: 3 additions & 0 deletions common/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ lock_api = "0.4"
siphasher = "1"
num-complex.workspace = true

[target.'cfg(all(target_arch = "wasm32", not(target_os = "wasi")))'.dependencies]
getrandom = { workspace = true, features = ["wasm_js"] }

Copy link
Member Author

@youknowone youknowone Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[target.'cfg(all(target_arch = "wasm32", not(target_os = "wasi")))'.dependencies]
getrandom = { workspace = true, features = ["wasm_js"] }

This is wrong.

Copy link
Member

@coolreader18 coolreader18 Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, true. I guess that should be enabled by a js feature flag that common exposes.

[target.'cfg(windows)'.dependencies]
widestring = { workspace = true }
windows-sys = { workspace = true, features = [
Expand Down