-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Now passing test_math from 3.13.2 with some caveat #5610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4dd3ff8 to
594a330
Compare
|
I am a bit confused by the libc vs musl situation. Which version fits to CPython behavior? Does CPython follow musl implementation? |
|
CPython uses the system's libm, so on most system its probably going to be libc's libm. Meanwhile, the Rust's libm is based on musl's libm. |
ee05a75 to
7191aae
Compare
Implemnted fma in math module.
7191aae to
af42192
Compare
youknowone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Implemnted fma in math module.
There are incompatibilities in the implementation of fma from libc vs musl.
I have added the tests that shows the differences here,