Skip to content

Rewrite of winreg module and bump to 3.13.2 #5594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 2 commits into from
Dec 5, 2025
Merged

Rewrite of winreg module and bump to 3.13.2 #5594

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
517987c
rewrite of winreg module and add test_winreg
arihant2math Mar 10, 2025
d8dde12
Complete winreg
youknowone Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Complete winreg
  • Loading branch information
@youknowone
youknowone committed Dec 5, 2025
commit d8dde123b1489ce78482607369b47764b0475ef8
29 changes: 1 addition & 28 deletions Lib/test/test_winreg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,14 +212,10 @@ def _test_named_args(self, key, sub_key):

class LocalWinregTests(BaseWinregTests):

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_registry_works(self):
self._test_all(HKEY_CURRENT_USER)
self._test_all(HKEY_CURRENT_USER, "日本-subkey")

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_registry_works_extended_functions(self):
# Substitute the regular CreateKey and OpenKey calls with their
# extended counterparts.
Expand All @@ -232,8 +228,6 @@ def test_registry_works_extended_functions(self):

self._delete_test_data(HKEY_CURRENT_USER)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_named_arguments(self):
self._test_named_args(HKEY_CURRENT_USER, test_key_name)
# Use the regular DeleteKey to clean up
Expand All @@ -251,8 +245,6 @@ def test_nonexistent_remote_registry(self):
connect = lambda: ConnectRegistry("abcdefghijkl", HKEY_CURRENT_USER)
self.assertRaises(OSError, connect)

# TODO: RUSTPYTHON
@unittest.skip("flaky")
def testExpandEnvironmentStrings(self):
r = ExpandEnvironmentStrings("%windir%\\test")
self.assertEqual(type(r), str)
Expand Down Expand Up @@ -299,8 +291,6 @@ def run(self):
DeleteKey(HKEY_CURRENT_USER, test_key_name+'\\changing_value')
DeleteKey(HKEY_CURRENT_USER, test_key_name)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_long_key(self):
# Issue2810, in 2.6 and 3.1 when the key name was exactly 256
# characters, EnumKey raised "WindowsError: More data is
Expand All @@ -315,8 +305,6 @@ def test_long_key(self):
DeleteKey(HKEY_CURRENT_USER, '\\'.join((test_key_name, name)))
DeleteKey(HKEY_CURRENT_USER, test_key_name)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_dynamic_key(self):
# Issue2810, when the value is dynamically generated, these
# raise "WindowsError: More data is available" in 2.6 and 3.1
Expand Down Expand Up @@ -351,8 +339,6 @@ def test_reflection_unsupported(self):
finally:
DeleteKey(HKEY_CURRENT_USER, test_key_name)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_setvalueex_value_range(self):
# Test for Issue #14420, accept proper ranges for SetValueEx.
# Py2Reg, which gets called by SetValueEx, was using PyLong_AsLong,
Expand All @@ -365,8 +351,6 @@ def test_setvalueex_value_range(self):
finally:
DeleteKey(HKEY_CURRENT_USER, test_key_name)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_setvalueex_negative_one_check(self):
# Test for Issue #43984, check -1 was not set by SetValueEx.
# Py2Reg, which gets called by SetValueEx, wasn't checking return
Expand All @@ -384,8 +368,6 @@ def test_setvalueex_negative_one_check(self):
finally:
DeleteKey(HKEY_CURRENT_USER, test_key_name)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_queryvalueex_return_value(self):
# Test for Issue #16759, return unsigned int from QueryValueEx.
# Reg2Py, which gets called by QueryValueEx, was returning a value
Expand All @@ -402,8 +384,6 @@ def test_queryvalueex_return_value(self):
finally:
DeleteKey(HKEY_CURRENT_USER, test_key_name)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_setvalueex_crash_with_none_arg(self):
# Test for Issue #21151, segfault when None is passed to SetValueEx
try:
Expand All @@ -417,8 +397,6 @@ def test_setvalueex_crash_with_none_arg(self):
finally:
DeleteKey(HKEY_CURRENT_USER, test_key_name)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_read_string_containing_null(self):
# Test for issue 25778: REG_SZ should not contain null characters
try:
Expand All @@ -443,16 +421,13 @@ def test_remote_registry_works(self):

@unittest.skipUnless(WIN64_MACHINE, "x64 specific registry tests")
class Win64WinregTests(BaseWinregTests):
# TODO: RUSTPYTHON
@unittest.expectedFailure

def test_named_arguments(self):
self._test_named_args(HKEY_CURRENT_USER, test_key_name)
# Clean up and also exercise the named arguments
DeleteKeyEx(key=HKEY_CURRENT_USER, sub_key=test_key_name,
access=KEY_ALL_ACCESS, reserved=0)

# TODO: RUSTPYTHON
@unittest.expectedFailure
@unittest.skipIf(win32_edition() in ('WindowsCoreHeadless', 'IoTEdgeOS'), "APIs not available on WindowsCoreHeadless")
def test_reflection_functions(self):
# Test that we can call the query, enable, and disable functions
Expand Down Expand Up @@ -538,8 +513,6 @@ def test_disable_reflection(self):
DeleteKeyEx(HKEY_CURRENT_USER, test_reflect_key_name,
KEY_WOW64_32KEY, 0)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_exception_numbers(self):
with self.assertRaises(FileNotFoundError) as ctx:
QueryValue(HKEY_CLASSES_ROOT, 'some_value_that_does_not_exist')
Expand Down
Loading
Loading