Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Fixed and Improved some Japanese Translations #398

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Advizormcpe1
Copy link

No description provided.

Copy link
Owner

@Rudloff Rudloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks but can you please explain what was wrong with the previous translations and what exactly you fixed?

@@ -93,7 +93,7 @@
"version": "2021.04.01",
"dist": {
"type": "zip",
"url": "https://github.com/ytdl-org/youtube-dl/archive/2021.04.01.zip"
"url": "https://github.com/ytdl-org/youtube-dl/archive/2021.06.06.zip"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks unrelated.

@@ -53,11 +53,11 @@ msgstr "よく使われる形式"

#: templates/info.tpl:35
msgid "Best"
msgstr "最高品質"
msgstr "最高品質(mp4形式)"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MP4 is not mentioned in the source string. (And choosing this option does not always guarantee an MP4 format.)


#: templates/info.tpl:36
msgid "Remux best video with best audio"
msgstr "最高品質に再エンコード"
msgstr "最高品質の音声と動画をmkvに再エンコード"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MKV is not mentioned in the source string.
If you think the format should be mentioned, please open an issue about this, but here is not the place to add it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants