[WIP] This request has the notify feature for the wire for any new action (like, republish, new post) #2826

PYRET1C · 2024-01-07T16:15:44Z

There are some known issues right now like:

the toggle notify button of wire does not work on the settings page
there are duplicate notifications each time there is a update

if you find any other issue please let me know and also if you know how to resolve the above mentioned issues then also let me know.
Thanks and Regards

This reverts commit 4d60af0.

PYRET1C · 2024-01-07T16:18:34Z

@defnax Please review

defnax · 2024-01-07T20:15:32Z

Im not available, needs reviewed by @csoler

defnax · 2024-01-11T21:09:49Z

retroshare-gui/src/gui/NewsFeed.cpp

+    case RsWireEventCode::NEW_POST:
+        addFeedItem( new WireNotifyGroupItem(this, NEWSFEED_WIRELIST, pe->mWireGroupId, false, true));
+        break;
+    case RsWireEventCode::POST_UPDATED:


im wondering why you added for every event a addfeeItem thats to much :)
maybe you need only when a

NEW_WIRE (a new user joind to wire)
NEW_POST (user posted a tweet )
NEW_REPLY (replied/commented to a post)
NEW_REPUBLISH ( a user republished a tweet)

this i think not needed as feed notify
NEW_LIKE ( maybe notify this only on wire button count and in wiredialog)
WIRE_UPDATED (this not needs notify as feeditem, its i think for internaly update the wire user list when im right)
POST_UPDATED (this not needs a notify as feeditem, its for update the posts when there is new posts or when im right)

yea you are right i will only add for the 4 items you said.
the WIRE_UPDATED is the one where someone changes their profile photo or the tagline.
the POST_UPDATED is the one where someone updates their old post.

defnax · 2024-01-12T09:53:00Z

you need to remove this, then the two double notiy is gone

    case RsWireEventCode::WIRE_UPDATED:
        addFeedItem( new WireNotifyGroupItem(this, NEWSFEED_WIRELIST, pe->mWireGroupId, false, true));
        break;
    case RsWireEventCode::POST_UPDATED:
        addFeedItem( new WireNotifyGroupItem(this, NEWSFEED_WIRELIST, pe->mWireGroupId, false, true));
        break;

for the NEW_LIKE notify you need implement a different notify without feeditems

defnax · 2024-01-12T09:57:41Z

notify for NEW_POST, NEW_REPLY, NEW_REPUBLISH works but shows all the same empty content.
i dont know if you want create for every wire feeditems own method or new ui for new post, reply or republish.

the NEW_WIRE not works, when i created a new wire account i doesnt get any notify in activity

defnax · 2024-01-12T09:59:31Z

In the Wiredialog i doesnt see yet any notify what is new, seems you added more activity feed notify

defnax · 2024-01-12T11:13:22Z

the toggle notify button of wire does not work on the settings page

seems used wrong values for me it works with this

#ifdef RS_USE_WIRE
const uint32_t RS_FEED_TYPE_WIRE  = 0x8000;
#endif

PYRET1C · 2024-01-14T07:30:17Z

retroshare-gui/src/gui/MainWindow.cpp

 			return true ;
 		 default:
+
+#ifdef RS_USE_WIRE


yea, i missed that, i will correct it.

defnax · 2024-02-11T22:01:16Z

@PYRET1C any news?

PYRET1C · 2024-02-12T07:35:57Z

Hello defnax, I am still resolving some compilation errors. I think I will release the update this week.

…

On Mon, Feb 12, 2024 at 3:31 AM defnax ***@***.***> wrote: @PYRET1C <https://github.com/PYRET1C> any news? — Reply to this email directly, view it on GitHub <#2826 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVG3YF3R3BXSSCAYZB2UUFTYTE5TRAVCNFSM6AAAAABBQNRRQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXHA4DMNBUGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

defnax · 2024-02-25T18:57:55Z

hi any updates? i see not more online in rs @PYRET1C

defnax · 2024-02-27T08:45:06Z

@PYRET1C this week you will push your changes?

PYRET1C · 2024-02-28T07:15:57Z

Hello defnax, sorry for the late reply, i was busy elsewhere. I am still stuck at that error, I tried many different things but I am not able to resolve it. Maybe cyril can help, i will try to push changes as soon as possible. Sorry for the late reply again.

…

On Tue, Feb 27, 2024 at 2:15 PM defnax ***@***.***> wrote: @PYRET1C <https://github.com/PYRET1C> this week you will push your changes? — Reply to this email directly, view it on GitHub <#2826 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVG3YF6L3QCVZDCWTRPSJF3YVWMJ5AVCNFSM6AAAAABBQNRRQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRWGA2TANJTGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

defnax · 2024-02-28T08:23:50Z

normaly best is step by step small improvements, you doing big things at the same time?
best come online in retroshare and ask cyril.
without the latest code not easy to know what happening

PYRET1C · 2024-02-28T09:11:51Z

yes you are right, i thought it was a small addition, but it turned out a bit big than i expected. i will push the code as soon as possible.

defnax · 2024-02-28T09:29:20Z

i prever small prs, and not work few weeks on a big code changes.
i do mostly small prs, i know your changes is big on wire

PYRET1C · 2024-02-29T07:21:57Z

Yeah, this time i under estimated the code development. my bad

defnax · 2024-03-04T20:25:05Z

when comes the updates? cant wait :D

PYRET1C · 2024-03-05T18:23:23Z

@defnax Hello, this is the issue i am facing while compilation:

D:/new/RetroShare/retroshare-gui/src/gui/feeds/WireNotifyPostItem.h:29:7: note: forward declaration of
class Ui::WireNotifyPostItem'
29 | class WireNotifyPostItem;
| ^~~~~~~~~~~~~~~~~~
D:/new/RetroShare/retroshare-gui/src/gui/feeds/WireNotifyPostItem.cpp:476:11: error: invalid use of incomplete type 'class Ui::WireNotifyPostItem'
476 | ui->expandButton->setToolTip(tr("Hide"));
| ^~
D:/new/RetroShare/retroshare-gui/src/gui/feeds/WireNotifyPostItem.h:29:7: note: forward declaration of
class Ui::WireNotifyPostItem'
29 | class WireNotifyPostItem;
| ^~~~~~~~~~~~~~~~~~
D:/new/RetroShare/retroshare-gui/src/gui/feeds/WireNotifyPostItem.cpp:482:11: error: invalid use of incomplete type 'class Ui::WireNotifyPostItem'
482 | ui->expandFrame->hide();
| ^~
D:/new/RetroShare/retroshare-gui/src/gui/feeds/WireNotifyPostItem.h:29:7: note: forward declaration of
class Ui::WireNotifyPostItem'
29 | class WireNotifyPostItem;
| ^~~~~~~~~~~~~~~~~~
D:/new/RetroShare/retroshare-gui/src/gui/feeds/WireNotifyPostItem.cpp:483:11: error: invalid use of incomplete type 'class Ui::WireNotifyPostItem'
483 | ui->expandButton->setIcon(FilesDefs::getIconFromQtResourcePath(QString(":/icons/png/down-arrow.png")));
| ^~
D:/new/RetroShare/retroshare-gui/src/gui/feeds/WireNotifyPostItem.h:29:7: note: forward declaration of
class Ui::WireNotifyPostItem'
29 | class WireNotifyPostItem;
| ^~~~~~~~~~~~~~~~~~
D:/new/RetroShare/retroshare-gui/src/gui/feeds/WireNotifyPostItem.cpp:484:11: error: invalid use of incomplete type 'class Ui::WireNotifyPostItem'
484 | ui->expandButton->setToolTip(tr("Expand"));
| ^~
D:/new/RetroShare/retroshare-gui/src/gui/feeds/WireNotifyPostItem.h:29:7: note: forward declaration of
class Ui::WireNotifyPostItem'
29 | class WireNotifyPostItem;
| ^~~~~~~~~~~~~~~~~~

defnax · 2024-03-05T23:57:11Z

I can test this weekend when get time

PYRET1C · 2024-03-06T08:52:24Z

it won't compile first we need to decode that

defnax · 2024-03-06T09:15:26Z

witthout compiling i see one possible mistake here
classname wrong in ui file

fix this and hope its solved then

PYRET1C · 2024-03-06T10:04:40Z

yea i will fix it and test tonight

defnax · 2024-03-06T23:02:25Z

i get compiled the WireNotifyPostItem class, only there is some little issues i commented it out.
seems copy of GxsChannelPostItem :)
please commit the fixes before you continoue then people cant test this pr

defnax · 2024-03-08T09:35:27Z

i tested last night seems notify not really finished.
i see only dummy notify (NEW WIRE) in activities and count on wire button

PYRET1C · 2024-03-29T17:59:12Z

pushing in few minutes

defnax · 2024-03-30T07:15:24Z

not had time to test, but seems the notify feeds ,when you can finish it?
notifygroupitem and notifypostitem, always dummy feed
that needs to be finished first

defnax · 2024-03-30T07:32:09Z

seems you removed the soure file from the ui file
WireNotifyPostItem.ui

 <resources>
  <include location="../icons.qrc"/>
 </resources>

PYRET1C · 2024-03-30T08:59:35Z

which source file

PYRET1C · 2024-03-30T09:00:09Z

yes we fix the dummy feed issue, but first let's complete the notify issue.

PYRET1C · 2024-03-30T09:00:19Z

then we can add ui

defnax · 2024-03-30T09:08:20Z

WireNotifyPostItem.ui

when you look into the .ui file the resource was maybe removed by mistake
in WireNotifyPostItem.ui

PYRET1C · 2024-03-30T09:38:55Z

is it causing any problem?

defnax · 2024-03-30T09:44:07Z

is it causing any problem?

no problem but icons will be not shown then on that ui

PYRET1C · 2024-03-30T12:21:03Z

i will check it. till then
can you please test the rest.

defnax · 2024-03-30T12:57:21Z

i can test tonight im on work

defnax · 2024-03-30T21:45:14Z

there is same bug, the wire notify copies the last count somewhere from boards notify you forget something rename?
you need subscribe a board and whem you has counts it has same from boards on restart

then last count from wire never gets read

i has same count since last week

defnax · 2024-03-30T22:11:09Z

read the wire post feed not working on WireNotifyPostItem class
connect(ui->readAndClearButton, SIGNAL(clicked()), this, SLOT(readAndClearItem()));

seems you hasnt implemented yet?

void GxsChannelPostItem::readAndClearItem()
{
#ifdef DEBUG_ITEM
	std::cerr << "GxsChannelPostItem::readAndClearItem()";
	std::cerr << std::endl;
#endif
	readToggled(false);
	removeItem();
}

defnax · 2024-03-31T10:38:55Z

Or maybe the new wire notify doesnt need it (the read button) maybe im wrong?

PYRET1C · 2024-03-31T10:41:39Z

i thought i removed it, we can add it in later updates. can you please make a list of current issues you observed in the latest commit. it will help a lot

defnax · 2024-03-31T12:40:47Z

i see no new issue same like before,
i think there is no real place read all post from notify, not implemented yet or?
i think the read state never cleard

defnax · 2024-03-31T12:45:30Z

this i think wrong, it must be use notifypostitem

case RsWireEventCode::NEW_POST:
    addFeedItem( new WireNotifyGroupItem(this, NEWSFEED_WIRELIST, pe->mWireGroupId, false, true));
    break;

defnax · 2024-03-31T13:01:13Z

notify is working on read/clean is missed that will take some time too to implement or

defnax · 2024-03-31T16:23:15Z

i doesnt get worked following notify, i unfollowed and followed back no success,
and seems wire every account uses same follower list

post, reply, like and republish works without issues

defnax · 2024-04-11T19:29:16Z

hi any news it will be this summer finished?

PYRET1C · 2024-04-13T10:23:12Z

i hope so. i am trying to finish it as soon as possible.

defnax · 2024-04-24T07:20:56Z

hello what happend, any updates? please post your update to rs dev chat too

PYRET1C · 2024-04-24T13:22:05Z

I am a bit busy in this week. so no progress has been made. also i have a question is Retro share on ubuntu 22.04?

defnax · 2024-04-24T16:18:35Z

Hi, you know this place not right?
You need start retroshare and ask there in dev chat or dev forumy there listing lots of testers and some devs
Here only me alone

PYRET1C · 2024-04-25T13:53:23Z

yes, i know. i changed my PC and tried installing Retroshare and it is not working on ubuntu 22.04 that is why i asked

defnax · 2024-08-26T19:17:42Z

@PYRET1C you will finish it this year?

PYRET1C added 3 commits January 1, 2024 23:48

[WIP] Adding the notify feature in the wire

4d60af0

adding the notify feature for wire

6f07bb0

Revert "[WIP] Adding the notify feature in the wire"

2f71929

This reverts commit 4d60af0.

PYRET1C mentioned this pull request Jan 7, 2024

[WIP] This PR includes the lib-retroshare changes for the notify feature of wire RetroShare/libretroshare#133

Merged

defnax reviewed Jan 11, 2024

View reviewed changes

PYRET1C commented Jan 14, 2024

View reviewed changes

retroshare-gui/src/gui/MainWindow.cpp

return true ;

default:

#ifdef RS_USE_WIRE

Copy link

Contributor Author

PYRET1C Jan 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, i missed that, i will correct it.

added the gui of activity tab for wire

a6ed28c

corrected the ui of wire dialog

e5de396

defnax mentioned this pull request Mar 12, 2025

[WIP] Wire Notify #2921

Closed

This was referenced Dec 8, 2025

Wire notify #3067

Closed

Wire Notify #3068

Open

[WIP] This request has the notify feature for the wire for any new action (like, republish, new post) #2826

Are you sure you want to change the base?

[WIP] This request has the notify feature for the wire for any new action (like, republish, new post) #2826

Uh oh!

Conversation

PYRET1C commented Jan 7, 2024

Uh oh!

PYRET1C commented Jan 7, 2024

Uh oh!

defnax commented Jan 7, 2024

Uh oh!

defnax Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PYRET1C Jan 14, 2024

Choose a reason for hiding this comment

Uh oh!

defnax commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

defnax commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

defnax commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

defnax commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PYRET1C Jan 14, 2024

Choose a reason for hiding this comment

Uh oh!

defnax commented Feb 11, 2024

Uh oh!

PYRET1C commented Feb 12, 2024 via email

Uh oh!

defnax commented Feb 25, 2024

Uh oh!

defnax commented Feb 27, 2024

Uh oh!

PYRET1C commented Feb 28, 2024 via email

Uh oh!

defnax commented Feb 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PYRET1C commented Feb 28, 2024

Uh oh!

defnax commented Feb 28, 2024

Uh oh!

PYRET1C commented Feb 29, 2024

Uh oh!

defnax commented Mar 4, 2024

Uh oh!

PYRET1C commented Mar 5, 2024

Uh oh!

defnax commented Mar 5, 2024

Uh oh!

PYRET1C commented Mar 6, 2024

Uh oh!

defnax commented Mar 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PYRET1C commented Mar 6, 2024

Uh oh!

defnax commented Mar 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

defnax commented Mar 8, 2024

Uh oh!

PYRET1C commented Mar 29, 2024

Uh oh!

defnax commented Mar 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

defnax commented Mar 30, 2024

Uh oh!

PYRET1C commented Mar 30, 2024

Uh oh!

PYRET1C commented Mar 30, 2024

defnax Jan 11, 2024 •

edited

Loading

defnax commented Jan 12, 2024 •

edited

Loading

defnax commented Jan 12, 2024 •

edited

Loading

defnax commented Jan 12, 2024 •

edited

Loading

defnax commented Jan 12, 2024 •

edited

Loading

defnax commented Feb 28, 2024 •

edited

Loading

defnax commented Mar 6, 2024 •

edited

Loading

defnax commented Mar 6, 2024 •

edited

Loading

defnax commented Mar 30, 2024 •

edited

Loading

defnax commented Mar 30, 2024 •

edited

Loading

defnax commented Mar 30, 2024 •

edited

Loading