some gui quirks #2608
Open
some gui quirks #2608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR seems to cause a crash: open the statistics, then close it using the Quit button. After 2 secs, the program crashes. |
Contributor
Author
|
commented out wa_deleteonclose. |
Contributor
|
to free memory on close. before opening->clicked through all tabs->after closing without WA_DeleteOnClose: 180->225->225 ; ->225->225... with WA_DeleteOnClose: 180->226->187 ; ->224->189... There is a mud with spaceotabulation, so don't poke me for doing automatic things for indentation, instead of understanding what should be there for new code. 'tis no more saves last opened statistics' tab, but hopefully nobody needs such a thing.
retroshare crashes
Only silhouette of word instead of time no more. This is maximum length of time representation, but auto shrinkable.
Make the setting great again
As qt says: Ownership of the menu is not transferred to the tool button.
delete delegatesforcolumn
and comment out quit-close button per cyril taste
As qt says: the view does not take ownership of the model.
"Conditional jump or move depends on uninitialised value"
It still shrinks for some amount, but less. What exactly cause such behaviour from post to post still unknown.
Contributor
Author
|
Nah, it would be cumbersome. What for, if there is the pr already, and
it's even richer than just mere one commit ¯\_(ツ)_/¯
|
G10h4ck
force-pushed
the
master
branch
2 times, most recently
from
1f64d0b to
67762c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.