Skip to content

Add a notification when GxsId come back in lobby.#2501

Open
PhenomRetroShare wants to merge 1 commit intoRetroShare:masterfrom
PhenomRetroShare:Add_ChatLob_ComeBackNotify
Open

Add a notification when GxsId come back in lobby.#2501
PhenomRetroShare wants to merge 1 commit intoRetroShare:masterfrom
PhenomRetroShare:Add_ChatLob_ComeBackNotify

Conversation

@PhenomRetroShare
Copy link
Contributor

@PhenomRetroShare PhenomRetroShare commented Nov 6, 2021

This can be setted even if GxsId is offline by using its name in
TextBrowser.

@defnax
Copy link
Contributor

defnax commented Nov 21, 2021

@G10h4ck @csoler

@csoler
Copy link
Contributor

csoler commented Nov 29, 2021

I tried it but didn't hear any sound. I think the problem is that you use the same notification than when a new msg arrives, so if sounds for new messages are desactivated, your new functionality will not work either. If I'm correctly understanding this, then you should probably create a new notification name and allow in preference to choose which sound to use, so that it's saved in Settings where the soundManager will look for it.

@PhenomRetroShare PhenomRetroShare force-pushed the Add_ChatLob_ComeBackNotify branch from 7a9af29 to 7adc865 Compare November 30, 2021 11:28
@PhenomRetroShare
Copy link
Contributor Author

PhenomRetroShare commented Nov 30, 2021

Updated and I've added a tooltip to tell if the sound event is unchecked.

@defnax
Copy link
Contributor

defnax commented Dec 2, 2021 •
edited
Loading

But only sound notify?
would be nice some toaster or notify in chat room too if user its back again

test:
sound not worked, after i come back is unchecked the notify

@PhenomRetroShare
Copy link
Contributor Author

PhenomRetroShare commented Dec 2, 2021

Why add a notify (like when someone talk to you)?
If you're not around, he may have left the chat room.
If you react 1 hour later, there is no interest...

@PhenomRetroShare
Copy link
Contributor Author

PhenomRetroShare commented Dec 14, 2021

@csoler ;)

@defnax
Copy link
Contributor

defnax commented Dec 14, 2021

@csoler this needs to be checked

@G10h4ck G10h4ck force-pushed the master branch 3 times, most recently from b30a9f4 to cfb210e Compare January 11, 2022 10:43
@PhenomRetroShare PhenomRetroShare force-pushed the Add_ChatLob_ComeBackNotify branch from 7adc865 to 34ac32f Compare January 15, 2022 12:09
@csoler
Copy link
Contributor

csoler commented Jan 16, 2022

wanted to re-try this PR but checkout pr/2501 doesn't work. Might be related to the recent split into submodules.

@PhenomRetroShare PhenomRetroShare force-pushed the Add_ChatLob_ComeBackNotify branch from 34ac32f to 246a369 Compare January 16, 2022 12:50
@PhenomRetroShare
Copy link
Contributor Author

PhenomRetroShare commented Jan 16, 2022

git checkout refs/remotes/origin/pr/2501
works fine here. (detached Head)

G10h4ck
G10h4ck reviewed Jan 16, 2022
View reviewed changes
retroshare-gui/src/gui/chat/ChatLobbyDialog.cpp Outdated
break ;
else
rstime::rs_usleep(1000*300) ;
std::this_thread::sleep_for(std::chrono::microseconds(1000*300)) ;
Copy link
Contributor

@G10h4ck G10h4ck Jan 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just use milliseconds(300) instead

Copy link
Contributor Author

@PhenomRetroShare PhenomRetroShare Jan 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@PhenomRetroShare PhenomRetroShare force-pushed the Add_ChatLob_ComeBackNotify branch from 246a369 to 25c4c8c Compare January 16, 2022 15:46
@PhenomRetroShare PhenomRetroShare force-pushed the Add_ChatLob_ComeBackNotify branch 2 times, most recently from b6151cd to 475d15f Compare February 11, 2022 19:11
@PhenomRetroShare PhenomRetroShare force-pushed the Add_ChatLob_ComeBackNotify branch from 475d15f to 216b871 Compare March 24, 2022 18:31
@PhenomRetroShare PhenomRetroShare force-pushed the Add_ChatLob_ComeBackNotify branch from 216b871 to eb37b16 Compare October 15, 2022 10:16
@defnax
Copy link
Contributor

defnax commented Oct 15, 2022

@csoler

@defnax
Copy link
Contributor

defnax commented Nov 24, 2022

Another idea, dont know if possible but when chat user joins he gets notify that i mentoined him with the right text what i wrote or send him optional as mail the mention

@PhenomRetroShare PhenomRetroShare force-pushed the Add_ChatLob_ComeBackNotify branch from eb37b16 to 580fd7b Compare March 18, 2023 15:08
@defnax
Copy link
Contributor

defnax commented Apr 5, 2023

offline chat mention would be nice, maybe someone mentioned me but i wasnt online in the chat, when i come back online show the mention with the text

@PhenomRetroShare
Copy link
Contributor Author

PhenomRetroShare commented Apr 6, 2023

You already have notifications for that. ;)

@G10h4ck G10h4ck force-pushed the master branch 2 times, most recently from 1f64d0b to 67762c1 Compare November 27, 2023 01:08
@PhenomRetroShare
Add a notification when GxsId come back in lobby.
dac82bf 
This can be setted even if GxsId is offline by using its name in
TextBrowser.
@PhenomRetroShare PhenomRetroShare force-pushed the Add_ChatLob_ComeBackNotify branch from 580fd7b to dac82bf Compare January 3, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@G10h4ck G10h4ck G10h4ck left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PhenomRetroShare @defnax @csoler @G10h4ck