-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve completion of methods arguments #82
Conversation
- Look for methods for second and following classes in objects with multiple classes. - Always run code to build completion data as a Neovim job. - Build the `args_` file right after building the corresponding `objls_` file. - Add time to build `objls_` + `args_` to `:RDebugInfo`.
This pull request should be tried with the branch Building an |
oh let me try it! |
|
oh wow, I still need coffee this morning :) I have to make some change to a project, I will report back in 1 h ( I will use your PR) |
In this example, the R documentation is shared by two functions and the |
This feels very fast already |
The completion by |
collapse = clpstr) | ||
luastr <- paste0("{{label = '", luastr, "', cls = 'm', env = '", env, "'}}") | ||
return(luastr) | ||
for (obc in objclass) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
Well, I have worked roughly 1 hour and it works perfectly fine. Speed is not comparable as it was before. You did a very nice job here :) I do not see any problem at mergin this 👍 |
I ran it with Valgrind and there was no invalid read or write in the C code. So, I believe that it's safe to merge. If any bugs appear, we will fix them. |
I have tried it also on a Window machine and no issue. |
Thank you! |
Just need to merge the cmp branch |
I'll do it... Thanks for remembering! |
args_
file right after building the correspondingobjls_
file.objls_
+args_
to:RDebugInfo
.