Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: add some notes about versioning and rework the README a bit #240

Merged
merged 9 commits into from
Oct 4, 2024

Conversation

wurli
Copy link
Contributor

@wurli wurli commented Oct 4, 2024

As discussed in #237, this PR aims to make it clear to the users when and why breaking changes might occur, and what they can do about it. I've also taken the opportunity to reorganise the README a bit; I've aimed to make it a bit easier to skim-read, and I also added a screenshot at the top.

docs: increase screenshot image size

docs: de-centre readme title

docs: move version badge to top of readme

docs: move version badge to VERY top of readme

docs: update screenshot

chore: very minor updates to the readme

typo

another typo

rewording

indentation
@wurli
Copy link
Contributor Author

wurli commented Oct 4, 2024

Once this PR is merged I think all we'll need to do is create a 0.1.0 release on GitHub, then it should be possible to merge #237 and bump the version to 0.2.0.

@jalvesaq
Copy link
Member

jalvesaq commented Oct 4, 2024

Once this PR is merged I think all we'll need to do is create a 0.1.0 release on GitHub, then it should be possible to merge #237 and bump the version to 0.2.0.

I agree, and the PR looks good to me.

I'm unsure if we should put the version number near the top of doc/R.nvim.txt as I did in Nvim-R. If we do, we must remember to update it with each new release.

@wurli
Copy link
Contributor Author

wurli commented Oct 4, 2024

If we do, we must remember to update it with each new release.

I think shields.io should automatically detect the latest release, so I don't think we'll need to manually change it whenever there's a new release. Currently on my fork it says 'no releases or repo not found'. I agree though, if for any reason it doesn't automatically update we should change it.

Copy link
Collaborator

@PMassicotte PMassicotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, it looks good to me. Thank you!

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@PMassicotte
Copy link
Collaborator

All good on my side!

@wurli
Copy link
Contributor Author

wurli commented Oct 4, 2024

Thanks! 🚀

@wurli wurli merged commit e1655b5 into R-nvim:main Oct 4, 2024
1 check passed
@wurli wurli deleted the versioning branch October 4, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants