Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not replace bracket subset matrix #208

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

PMassicotte
Copy link
Collaborator

@PMassicotte PMassicotte commented Aug 12, 2024

This PR will avoid using [[ on matrix. For example, this will leave this untouched

mat[, , 2]
mat[2 , ,  ]

@PMassicotte PMassicotte marked this pull request as draft August 12, 2024 16:30
…prator_replacement to build_extract_operator_replacement

feat(brackets.lua): add check to avoid processing single brackets with comma values to handle matrix subsetting correctly

fix(brackets.lua): improve condition to check for single child node instead of comma type to prevent incorrect processing
@PMassicotte PMassicotte force-pushed the do-not-replace-bracket-subset-matrix branch from ed55c2f to 05acf88 Compare August 12, 2024 16:39
@PMassicotte PMassicotte marked this pull request as ready for review August 12, 2024 16:40
@jalvesaq
Copy link
Member

Thank you!

@jalvesaq jalvesaq merged commit 7a42582 into main Aug 13, 2024
2 checks passed
@jalvesaq jalvesaq deleted the do-not-replace-bracket-subset-matrix branch August 16, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants