-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GitHub Actions] Setup Tests via Github Actions #561
Conversation
still need to add test changes for this to work
(whoops, I was about to make this PR on my fork instead of here!) |
9f7a40f
to
006ff0a
Compare
Using similar set up as to [here](https://github.com/marketplace/actions/coveralls-github-action)
Otherwise, scipy returns this error during installation: RuntimeError: Python version >= 3.7 required.
According to coverallsapp/github-action#4 (comment), this version works, unlike the official https://github.com/marketplace/actions/coveralls-github-action.
@Harveyt47 @mmcky I finally got 94.15% from coveralls.io: https://github.com/QuantEcon/QuantEcon.py/pull/561/checks?check_run_id=1633166620#step:7:15 -> https://coveralls.io/jobs/72880434. |
My fix is to do according to this comment: coverallsapp/github-action#4 (comment). |
Let me know if the commits need to be squashed. They are kind of messy. |
thanks @rht!. We will definitely Squash these commits. One question before we merge -- I see you added a GitHub Repo Secret for the Tokens Coveralls. Just wondering if we should use a |
Nope, I was in fact removing it.
|
Also, I removed .coveralls.yml instead, so it is no longer tied to travis-ci. |
I added another commit to remove pytest since it is no longer used in the latest version of this PR. |
Thanks @rht I struggled with the coveralls.io a bit. Is this still running |
Yes, this is still running |
Ready to be squashed. |
Thanks @rht -- it will be nice to have tests via GitHub Actions. |
No description provided.