-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis: Add macOS to the build matrix #448
Conversation
Note: the version shipped in xcode10 is 3.7. |
9409aba
to
c1f5412
Compare
6a48534
to
eea9fee
Compare
|
accbdae
to
109996e
Compare
thanks @rht -- this is great. I will check through the diff tomorrow and merge. |
c571bde
to
ecf400b
Compare
OK, I found the |
hey @rht we have had tests running on linux for quite some time. I'm not sure why you're getting non-deterministic results. Are you sure its not just a tolerance issue? |
Otherwise, I can't explain the error in the commit "TestTicTacToc: Skip test_loop and test_timer for darwin". There was an error of ~1e-5. |
So, the test flake disappeared in the dust just like that. |
thanks @rht for the PR! I will merge this and take a look at |
This fixes #359.