-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to access github Release Asset API. #525
Merged
+733
−8
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
65edbcf
Add ability to access github Release Asset API.
9b0eb60
PEP8 compliance (move imports & remove extra spacing)
ankona 6a6d5ca
Add requestBlobAndCheck to fix python3 result bug reported by @NicoHood
ankona d01da1d
Fix non-text files failing to upload in python3
ankona 47723c9
Ensure upload url hostname is used during uploads
ankona b57e1e0
fix incorrect headers supplied to obj contructors
ankona 77bb4d1
fix replay data for upload_asset test case
ankona a4f19c1
fix invalid-content-length for python > 3.5.1
ankona 778b78e
add content length to replaydata for unittest
ankona 85a167b
fix unclosed file warning
ankona File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,3 +35,4 @@ | |
| /developer.github.com/ | ||
| /gh-pages/ | ||
| /doc/doctrees/ | ||
| .vscode* | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,223 @@ | ||
| # -*- coding: utf-8 -*- | ||
|
|
||
| # ########################## Copyrights and license ############################ | ||
| # # | ||
| # Copyright 2012 Vincent Jacques <[email protected]> # | ||
| # Copyright 2012 Zearin <[email protected]> # | ||
| # Copyright 2013 AKFish <[email protected]> # | ||
| # Copyright 2013 Vincent Jacques <[email protected]> # # | ||
| # Copyright 2017 Chris McBride <[email protected]> # | ||
| # # | ||
| # This file is part of PyGithub. # | ||
| # http://pygithub.github.io/PyGithub/v1/index.html # | ||
| # # | ||
| # PyGithub is free software: you can redistribute it and/or modify it under # | ||
| # the terms of the GNU Lesser General Public License as published by the Free # | ||
| # Software Foundation, either version 3 of the License, or (at your option) # | ||
| # any later version. # | ||
| # # | ||
| # PyGithub is distributed in the hope that it will be useful, but WITHOUT ANY # | ||
| # WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS # | ||
| # FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more # | ||
| # details. # | ||
| # # | ||
| # You should have received a copy of the GNU Lesser General Public License # | ||
| # along with PyGithub. If not, see <http://www.gnu.org/licenses/>. # | ||
| # # | ||
| # ############################################################################## | ||
|
|
||
| import github.GithubObject | ||
|
|
||
|
|
||
| class GitReleaseAsset(github.GithubObject.CompletableGithubObject): | ||
| """ | ||
| This class represents GitReleaseAssets as returned by | ||
| GET /repos/:owner/:repo/releases/assets/:id | ||
| See: | ||
| https://developer.github.com/v3/repos/releases/#get-a-single-release-asset | ||
| """ | ||
|
|
||
| def __repr__(self): | ||
| return self.get__repr__({"url": self.url}) | ||
|
|
||
| @property | ||
| def url(self): | ||
| """ | ||
| :type: string | ||
| """ | ||
| self._completeIfNotSet(self._url) | ||
| return self._url.value | ||
|
|
||
| @property | ||
| def id(self): | ||
| """ | ||
| :type: integer | ||
| """ | ||
| self._completeIfNotSet(self._id) | ||
| return self._id.value | ||
|
|
||
| @property | ||
| def name(self): | ||
| """ | ||
| :type: string | ||
| """ | ||
| self._completeIfNotSet(self._name) | ||
| return self._name.value | ||
|
|
||
| @name.setter | ||
| def name(self, value): | ||
| """ | ||
| :type: string | ||
| """ | ||
| self._completeIfNotSet(self._name) | ||
| self._name.value = value | ||
|
|
||
| @property | ||
| def label(self): | ||
| """ | ||
| :type: string | ||
| """ | ||
| self._completeIfNotSet(self._label) | ||
| return self._label.value | ||
|
|
||
| @label.setter | ||
| def label(self, value): | ||
| """ | ||
| :type: string | ||
| """ | ||
| self._completeIfNotSet(self._label) | ||
| self._label.value = value | ||
|
|
||
| @property | ||
| def content_type(self): | ||
| """ | ||
| :type: string | ||
| """ | ||
| self._completeIfNotSet(self._content_type) | ||
| return self._content_type.value | ||
|
|
||
| @property | ||
| def state(self): | ||
| """ | ||
| :type: string | ||
| """ | ||
| self._completeIfNotSet(self._state) | ||
| return self._state.value | ||
|
|
||
| @property | ||
| def size(self): | ||
| """ | ||
| :type: integer | ||
| """ | ||
| self._completeIfNotSet(self._size) | ||
| return self._size.value | ||
|
|
||
| @property | ||
| def download_count(self): | ||
| """ | ||
| :type: integer | ||
| """ | ||
| self._completeIfNotSet(self._download_count) | ||
| return self._download_count.value | ||
|
|
||
| @property | ||
| def created_at(self): | ||
| """ | ||
| :type: datetime | ||
| """ | ||
| self._completeIfNotSet(self._created_at) | ||
| return self._created_at.value | ||
|
|
||
| @property | ||
| def updated_at(self): | ||
| """ | ||
| :type: datetime | ||
| """ | ||
| self._completeIfNotSet(self._updated_at) | ||
| return self._updated_at.value | ||
|
|
||
| @property | ||
| def browser_download_url(self): | ||
| """ | ||
| :type: string | ||
| """ | ||
| self._completeIfNotSet(self._browser_download_url) | ||
| return self._browser_download_url.value | ||
|
|
||
| @property | ||
| def uploader(self): | ||
| """ | ||
| :type: github.NamedUser.NamedUser | ||
| """ | ||
| self._completeIfNotSet(self._uploader) | ||
| return self._uploader.value | ||
|
|
||
| def delete_asset(self): | ||
| """ | ||
| Delete asset from the release. | ||
| :rtype: bool | ||
| """ | ||
| headers, data = self._requester.requestJsonAndCheck( | ||
| "DELETE", | ||
| self.url | ||
| ) | ||
| return True | ||
|
|
||
| def update_asset(self, name, label=""): | ||
| """ | ||
| Update asset metadata. | ||
| :rtype: github.GitReleaseAsset.GitReleaseAsset | ||
| """ | ||
| assert isinstance(name, (str, unicode)), name | ||
| assert isinstance(label, (str, unicode)), label | ||
| post_parameters = { | ||
| "name": name, | ||
| "label": label | ||
| } | ||
| headers, data = self._requester.requestJsonAndCheck( | ||
| "PATCH", | ||
| self.url, | ||
| input=post_parameters | ||
| ) | ||
| return GitReleaseAsset(self._requester, headers, data, completed=True) | ||
|
|
||
| def _initAttributes(self): | ||
| self._url = github.GithubObject.NotSet | ||
| self._id = github.GithubObject.NotSet | ||
| self._name = github.GithubObject.NotSet | ||
| self._label = github.GithubObject.NotSet | ||
| self._uploader = github.GithubObject.NotSet | ||
| self._content_type = github.GithubObject.NotSet | ||
| self._state = github.GithubObject.NotSet | ||
| self._size = github.GithubObject.NotSet | ||
| self._download_count = github.GithubObject.NotSet | ||
| self._created_at = github.GithubObject.NotSet | ||
| self._updated_at = github.GithubObject.NotSet | ||
| self._browser_download_url = github.GithubObject.NotSet | ||
|
|
||
| def _useAttributes(self, attributes): | ||
| if "url" in attributes: # pragma no branch | ||
| self._url = self._makeStringAttribute(attributes["url"]) | ||
| if "id" in attributes: # pragma no branch | ||
| self._id = self._makeIntAttribute(attributes["id"]) | ||
| if "name" in attributes: # pragma no branch | ||
| self._name = self._makeStringAttribute(attributes["name"]) | ||
| if "label" in attributes: # pragma no branch | ||
| self._label = self._makeStringAttribute(attributes["label"]) | ||
| if "uploader" in attributes: # pragma no branch | ||
| self._uploader = github.NamedUser.NamedUser(self._requester, {}, \ | ||
| attributes["uploader"], completed=True) | ||
| if "content_type" in attributes: # pragma no branch | ||
| self._content_type = self._makeStringAttribute(attributes["content_type"]) | ||
| if "state" in attributes: # pragma no branch | ||
| self._state = self._makeStringAttribute(attributes["state"]) | ||
| if "size" in attributes: # pragma no branch | ||
| self._size = self._makeIntAttribute(attributes["size"]) | ||
| if "download_count" in attributes: # pragma no branch | ||
| self._download_count = self._makeIntAttribute(attributes["download_count"]) | ||
| if "created_at" in attributes: # pragma no branch | ||
| self._created_at = self._makeDatetimeAttribute(attributes["created_at"]) | ||
| if "updated_at" in attributes: # pragma no branch | ||
| self._updated_at = self._makeDatetimeAttribute(attributes["updated_at"]) | ||
| if "browser_download_url" in attributes: # pragma no branch | ||
| self._browser_download_url = self._makeStringAttribute(attributes["browser_download_url"]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldnt we change back the __hostname here? My subsequent api calls failed due to the host name assertion fails in requester..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See fix in #771