Release 1.59.0 #2563
Release 1.59.0 #2563
Conversation
| def __init__( | ||
| self, | ||
| integration_id=None, | ||
| private_key=None, | ||
| base_url=Consts.DEFAULT_BASE_URL, | ||
| *, | ||
| timeout=Consts.DEFAULT_TIMEOUT, |
There was a problem hiding this comment.
Without this, existing code like GithubIntegration(id, key, url, expiry) would silently use expiry as timeout. This breaks code that uses jwt_* arguments as positional arguments.
There was a problem hiding this comment.
I actually don't know what this syntax means. Could you point to a doc that explains it?
There was a problem hiding this comment.
Arguments after the bare * are keyword arguments only, they cannot be provided as positional arguments:
Parameters after “*” or “*identifier” are keyword-only parameters and may only be passed used keyword arguments.
https://docs.python.org/3.5/reference/compound_stmts.html#function-definitions
https://stackoverflow.com/questions/2965271/how-can-we-force-naming-of-parameters-when-calling-a-function/14298976#14298976
…l to githubIntegration with positional arguments
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2563 +/- ##
=======================================
Coverage ? 98.35%
=======================================
Files ? 131
Lines ? 13161
Branches ? 0
=======================================
Hits ? 12945
Misses ? 216
Partials ? 0 ☔ View full report in Codecov by Sentry. |
No description provided.