Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata updates for v2.0.0 #535

Merged
merged 2 commits into from
Apr 18, 2023
Merged

metadata updates for v2.0.0 #535

merged 2 commits into from
Apr 18, 2023

Conversation

dbkeitel
Copy link
Collaborator

@dbkeitel dbkeitel commented Apr 17, 2023 •
edited
Loading

Readme and changelog. Helpful enough for non-experts?

@dbkeitel dbkeitel added the documentation anything about documentation label Apr 17, 2023
@dbkeitel dbkeitel self-assigned this Apr 17, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023 •
edited
Loading

Codecov Report

Merging #535 (69eadad) into master (582646b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #535   +/-   ##
=======================================
  Coverage   74.56%   74.56%           
=======================================
  Files          23       23           
  Lines        4396     4396           
=======================================
  Hits         3278     3278           
  Misses       1118     1118
Flag Coverage Δ
unittests 74.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 582646b...69eadad. Read the comment docs.

@dbkeitel dbkeitel added this to the Release 2.0.0 milestone Apr 18, 2023
Rodrigo-Tenorio
Rodrigo-Tenorio approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@Rodrigo-Tenorio Rodrigo-Tenorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you went through the hassle of updating examples (:clap:), I'd say everything is as clear as it could be and there are enough resources to make sense of this.

👍

@dbkeitel dbkeitel merged commit f5f0480 into master Apr 18, 2023
@dbkeitel dbkeitel deleted the prepare-2.0.0 branch April 18, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rodrigo-Tenorio Rodrigo-Tenorio Rodrigo-Tenorio approved these changes

Assignees

@dbkeitel dbkeitel

Labels
documentation anything about documentation
Projects
None yet
Milestone
Release 2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dbkeitel @Rodrigo-Tenorio