-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Control Master #1328
Comments
Its not in the horizon yet, unfortunately. It relies on a particular feature of Unix Domain sockets ( passing ancillary data ), that's not easy to realize in Windows. |
Hi @manojampalam , Perhaps it's best to not use Unix Domain sockets (only available over WSL) and implement a simple communication over pipes. In any case I hope you can implement it soon, as the VSCode Remote SSH uses this functionality. Regards. |
bump any status? |
This is exactly the older #405 |
I've been migrating over from Putty/Kitty to OpenSSH on Windows 10. Just realized that this isn't supported yet. Here's my 👍 to adding ControlMaster support. Would love to see it. |
I'm similar to mew1033, just migrated from PuTTY and multiplexing is the one feature that's preventing me from being able to drop PuTTY altogether. |
@lgretton This is definitely not multiplexing, but you can get sucky fake multiplexing using ProxyCommand. I did this:
It kinda sorta works. ¯\_(ツ)_/¯ |
Does MSFT still maintain this package? IMO it would be better for the team to upstream the changes. We are getting updates at a glacial pace and we still have many missing features. |
Can we at least have the client report that the feature is not supported instead of printing opaque errors about sockets, as though the feature were implemented but happened to have suffered some incidental mishap? |
Connection multiplexing should be a must-to-have feature. thanks a lot (and thanks to listen your community). ciao luigi |
Just back for the yearly ping. Any updates on possibly bringing ControlMaster to powershell ssh? Thanks! |
Note comment in #405 |
Do we think ControlMaster support will ever appear? This particular issue recently celebrated its fifth birthday :-( |
Not really a solution for control master support but a possible workaround for multiplexing is using wsl ssh, I just set it up for vscode remote dev (following this: microsoft/vscode-remote-release#937 (comment)) and it seems to work fine. The idea is basically to use a bat file containing this to bridge to wsl ssh:
where DESTINATION is the already open ssh tunnel. This is a bit ugly, it would be nice to get support for multiplexing on windows. |
Since commit 448b0c4 in PR git-lfs#5537 the GetExeAndArgs() function in our "ssh" package sets the default value of our "lfs.ssh.autoMultiplex" configuration option to "false" when running on Windows, and "true" otherwise. This choice was made because the SSH clients available on Windows may not support multiplexing SSH sessions over a single connection, as OpenSSH does with its ControlMaster and ControlPath options. Since some of these SSH clients may fail if they are passed the ControlMaster and ControlPath options, we require Windows users who want to use SSH multiplexing to explicitly enable it by setting the "lfs.ssh.autoMultiplex" option to "true". See also the discussion in: git-lfs#5537 (comment) However, our git-lfs-config(5) manual page was not updated in PR git-lfs#5537 to reflect the change in the default value of the "lfs.ssh.autoMultiplex" option on Windows, so we update it now. Note that users with the Git for Windows project installed will typically have a version of OpenSSH available which supports the ControlMaster option. However, the OpenSSH for Windows client may not support multiplexing, as noted in PowerShell/Win32-OpenSSH#1328.
I noticed in the previous roadmap the
Control Master
feature was not going to be ready for the initial release. Any plans to support this in the future?We have use cases for multiplexing ssh connections.
The text was updated successfully, but these errors were encountered: