Skip to content

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Oct 11, 2024

PR Summary

This pull request introduces several changes to the macOS packaging process, including updates to the build scripts and dependencies. The most significant changes involve adding a new packaging stage, removing the ronn dependency, and updating the man page generation process.

macOS Packaging Process:

  • Added a new PackageMac stage to the .vsts-ci/mac.yml file, which depends on the BuildMac stage and includes steps for macOS packaging using PowerShell. (.vsts-ci/mac.yml)

Dependency Management:

  • Removed the ronn dependency from the Start-PSBootstrap function in build.psm1 and the Get-PackageDependencies function in tools/packaging/packaging.psm1. (build.psm1) [1] (tools/packaging/packaging.psm1) [2]

Man Page Generation:

  • Updated the man page generation process to use roff instead of ronn in the New-ManGzip function in tools/packaging/packaging.psm1. (tools/packaging/packaging.psm1)
  • Added a new man page for pwsh in assets/manpage/pwsh.1. (assets/manpage/pwsh.1)

PR Context

macOS man page generation is failing. Checking in asset so we can get the release working.

PR Checklist

@microsoft-github-policy-service microsoft-github-policy-service bot added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Oct 14, 2024
@adityapatwardhan adityapatwardhan changed the title Checkin generataed manpage Checkin generated manpage Oct 14, 2024
@TravisEz13 TravisEz13 merged commit ac8ab0d into PowerShell:master Oct 14, 2024
@TravisEz13 TravisEz13 deleted the generate-manpage branch October 14, 2024 19:16
adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Oct 15, 2024
* checkin generataed manpage

* move ronn file into new folder

* update build and release to use new asset

* add a minimal macos packaging test

* add correct dependency for the macos packaging stage

* fix packaging error

* remove removing files
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Oct 17, 2024
adityapatwardhan pushed a commit that referenced this pull request Oct 22, 2024
* checkin generataed manpage

* move ronn file into new folder

* update build and release to use new asset

* add a minimal macos packaging test

* add correct dependency for the macos packaging stage

* fix packaging error

* remove removing files
adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Oct 31, 2024
* checkin generataed manpage

* move ronn file into new folder

* update build and release to use new asset

* add a minimal macos packaging test

* add correct dependency for the macos packaging stage

* fix packaging error

* remove removing files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.2.x-Done BackPort-7.4.x-Done BackPort-7.5.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants