Skip to content

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Sep 10, 2024

PR Summary

This pull request includes several changes to the pipeline configuration files to improve the build and validation processes. The most important changes include modifications to the variables and extends sections in the PowerShell-Release-Official.yml file, updates to the job configurations in the release-validate-sdk.yml template, and some refactoring for better maintainability.

Pipeline Configuration Updates:

  • Variables and Pool Names:

    • Added a new variable group for PoolNames in the .pipelines/PowerShell-Release-Official.yml file.
  • Extends Section Updates:

    • Updated the extends section to include imageName and poolName parameters for Windows, MacOS, and Linux SDK validation jobs in the .pipelines/PowerShell-Release-Official.yml file.

Job Configuration Updates:

  • Job Parameters:

    • Changed the jobtype parameter to poolName and added an imageName parameter in the .pipelines/templates/release-validate-sdk.yml file.
  • Job Pool Configuration:

    • Refactored the pool configuration to use the new poolName and imageName parameters, replacing the previous conditional logic based on jobtype.
  • Repository Path Adjustments:

    • Simplified the repository root path assignment by removing the conditional check for MacOS in the .pipelines/templates/release-validate-sdk.yml file. [1] [2]
  • NuGet Configuration Handling:

    • Enhanced the handling of the NuGet configuration file path to check for the existence of the file and use the appropriate path.

These changes collectively enhance the flexibility and maintainability of the pipeline configurations.

PR Context

We are not required and should not use OBP pools to run tests.

PR Checklist

@TravisEz13 TravisEz13 marked this pull request as ready for review September 10, 2024 21:35
@adityapatwardhan adityapatwardhan merged commit a9f81c5 into PowerShell:master Sep 10, 2024
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Sep 10, 2024
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Sep 10, 2024

📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull request Oct 8, 2024
adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.2.x-Done BackPort-7.4.x-Done BackPort-7.5.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants