-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Make some release tests run in a hosted pools #24270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adityapatwardhan
merged 10 commits into
PowerShell:master
from
TravisEz13:rebuild/v7.5.9-rebuild.10
Sep 10, 2024
Merged
Make some release tests run in a hosted pools #24270
adityapatwardhan
merged 10 commits into
PowerShell:master
from
TravisEz13:rebuild/v7.5.9-rebuild.10
Sep 10, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
approved these changes
Sep 10, 2024
Contributor
|
📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
chrisdent-de
pushed a commit
to chrisdent-de/PowerShell
that referenced
this pull request
Sep 12, 2024
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Sep 19, 2024
adityapatwardhan
added a commit
that referenced
this pull request
Sep 20, 2024
Co-authored-by: Travis Plunk <[email protected]>
TravisEz13
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
Oct 8, 2024
TravisEz13
added a commit
that referenced
this pull request
Oct 8, 2024
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Oct 15, 2024
adityapatwardhan
added a commit
that referenced
this pull request
Oct 15, 2024
This was referenced Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport-7.2.x-Done
BackPort-7.4.x-Done
BackPort-7.5.x-Done
CL-BuildPackaging
Indicates that a PR should be marked as a build or packaging change in the Change Log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request includes several changes to the pipeline configuration files to improve the build and validation processes. The most important changes include modifications to the
variablesandextendssections in thePowerShell-Release-Official.ymlfile, updates to the job configurations in therelease-validate-sdk.ymltemplate, and some refactoring for better maintainability.Pipeline Configuration Updates:
Variables and Pool Names:
PoolNamesin the.pipelines/PowerShell-Release-Official.ymlfile.Extends Section Updates:
extendssection to includeimageNameandpoolNameparameters for Windows, MacOS, and Linux SDK validation jobs in the.pipelines/PowerShell-Release-Official.ymlfile.Job Configuration Updates:
Job Parameters:
jobtypeparameter topoolNameand added animageNameparameter in the.pipelines/templates/release-validate-sdk.ymlfile.Job Pool Configuration:
poolNameandimageNameparameters, replacing the previous conditional logic based onjobtype.Repository Path Adjustments:
.pipelines/templates/release-validate-sdk.ymlfile. [1] [2]NuGet Configuration Handling:
These changes collectively enhance the flexibility and maintainability of the pipeline configurations.
PR Context
We are not required and should not use OBP pools to run tests.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).