Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete mention of separate 'Details' link in lists of GitHub checks #2935

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Remove obsolete mention of separate 'Details' link in lists of GitHub checks #2935

wants to merge 6 commits into from

Conversation

namurphy
Copy link
Member

@namurphy namurphy commented Jan 6, 2025 •
edited
Loading

Recently, GitHub changed its interface so that instead of clicking on Details in a list of checks, we click on the name of the check itself. This PR updates where this is discussed in a few places.

I still need to:

  • Either remove or update the picture in the doc guide that highlights where "Details" is

@github-actions github-actions bot added docs PlasmaPy Docs at http://docs.plasmapy.org GitHub Actions A continuous integration platform for automating tests and other tasks (see .github/ directory) contributor guide maintenance General updates to package infrastructure labels Jan 6, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.49%. Comparing base (8da7619) to head (322704c).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2935      +/-   ##
==========================================
- Coverage   95.28%   94.49%   -0.79%     
==========================================
  Files         108      108              
  Lines        9631     9631              
  Branches     1451     1451              
==========================================
- Hits         9177     9101      -76     
- Misses        273      343      +70     
- Partials      181      187       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added CI Related to continuous integration linters Code linters and autoformatters labels Jan 7, 2025
@namurphy namurphy marked this pull request as ready for review January 7, 2025 19:02
@namurphy namurphy requested a review from a team as a code owner January 7, 2025 19:02
@namurphy namurphy requested review from pheuer and removed request for a team January 7, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheuer pheuer Awaiting requested review from pheuer pheuer is a code owner automatically assigned from PlasmaPy/plasmapy-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CI Related to continuous integration contributor guide docs PlasmaPy Docs at http://docs.plasmapy.org GitHub Actions A continuous integration platform for automating tests and other tasks (see .github/ directory) linters Code linters and autoformatters maintenance General updates to package infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@namurphy