Arrays::getOpenClose(): efficiency fix - only accept array open tokens #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Arrays::getOpenClose()` method only _handled_ array open tokens, but _accepted_ both open as well as close tokens. This meant that for array close tokens, the method would not bow out early, while it should have. Fixed now. Includes some additional tests.
jrfnl
force-pushed
the
arrays/getopenclose-only-accept-openers
branch
from
19a8e3a to
f655b41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Arrays::getOpenClose()method only handled array open tokens, but accepted both open as well as close tokens. This meant that for array close tokens, the method would not bow out early, while it should have.Fixed now. Includes some additional tests.