PHP 8.1 | PassedParameters::hasParameters(): prevent false positives for first class callable declarations #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for first class callable declarations PHP 8.1 introduced a new callback declaration syntax, called "first class callables". This syntax can be easily confused with a function call. While it remains the responsibility of individual sniffs to verify if something is a function call before passing it to any of the `PassedParameters` methods, a little defensive coding to prevent incorrect results goes a long way. Includes tests. Refs: * https://wiki.php.net/rfc/first_class_callable_syntax
jrfnl
deleted the
php-8.1/passedparams-prevent-false-pos-first-class-callables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.1 introduced a new callback declaration syntax, called "first class callables". This syntax can be easily confused with a function call.
While it remains the responsibility of individual sniffs to verify if something is a function call before passing it to any of the
PassedParametersmethods, a little defensive coding to prevent incorrect results goes a long way.Includes tests.
Refs: