Tokens\Collections: simplify by implementing a magic __callStatic() method #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As much as possible, make all methods use (`private`) properties for the actual token arrays. Includes fixing up a few references to the `ooHierarchyKeywords()` method, which should reference the property.
Move most pertinent documentation to the properties and remove it from the methods in anticipation of removing most methods in favour of using a `__callStatic()` magic method. Includes minor doc fixes.
... for all methods without logic and where there has been no name-change between the (now deprecated) property and the replacement method. Includes simplifying the related tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tokens\Collections: internal change
As much as possible, make all methods use (
private) properties for the actual token arrays.Includes fixing up a few references to the
ooHierarchyKeywords()method, which should reference the property.Tokens\Collections: update documentation
Move most pertinent documentation to the properties and remove it from the methods in anticipation of removing most methods in favour of using a
__callStatic()magic method.Includes minor doc fixes.
Tokens\Collections: use magic __callStatic() method
... for all methods without logic and where there has been no name-change between the (now deprecated) property and the replacement method.
Includes simplifying the related tests.