UtilityMethodTestCase: fail test on missing test marker comment #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a test marker comment was not found, the `UtilityMethodTestCase::getTargetToken()` would search for the target token between the start of the file and the first test marker it _did_ find. This could lead to the wrong token being set as the `$stackPtr` for a test. This improves the `UtilityMethodTestCase::getTargetToken()` method by failing the test when the test marker comment cannot be found. The `$failTest` parameter to throw an exception instead of failing the test is not taken into account as when the test marker comment cannot be found, the correct test target can never be found, no matter what token types or content is passed. Includes unit test.
jrfnl
deleted the
utilitymethodtestcase/gettargetmethod-fail-on-missing-test-comment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a test marker comment was not found, the
UtilityMethodTestCase::getTargetToken()would search for the target token between the start of the file and the first test marker it did find.This could lead to the wrong token being set as the
$stackPtrfor a test.This improves the
UtilityMethodTestCase::getTargetToken()method by failing the test when the test marker comment cannot be found.The
$failTestparameter to throw an exception instead of failing the test is not taken into account as when the test marker comment cannot be found, the correct test target can never be found, no matter what token types or content is passed.Includes unit test.