FunctionDeclarations::getParameters(): compatibility with the PHP 8 identifier name tokenization #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dentifier name tokenization The PHP 8 identifier name tokens can occur as part of a (union) type declaration for a function parameter, as well as within default values. This commit adjusts the `FunctionDeclarations::getParameters()` method to allow for these new tokens. The existing unit tests already cover this change.
jrfnl
deleted the
php-8.0/functiondeclarations-getparameters-identifier-name-compatibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHP 8 identifier name tokens can occur as part of a (union) type declaration for a function parameter, as well as within default values.
This commit adjusts the
FunctionDeclarations::getParameters()method to allow for these new tokens.The existing unit tests already cover this change.