Skip to content

Conversation

@GaryJones
Copy link
Contributor

Checked with a Grammarly and myself :-)

@jrfnl jrfnl added this to the 1.0.0 milestone Mar 28, 2020
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He Gary, thanks a lot for this!

I've left a few comments/questions in-line. Other than that, this same text is also used in the README.md, so that will probably also need updating.

@GaryJones
Copy link
Contributor Author

Feedback incorporated, and README updated.

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gary for making those changes and updating the Readme as well. I've found just a couple of very minor issues still. If you like, I can fix those up myself ?

@GaryJones
Copy link
Contributor Author

5 bits of feedback added in, along with adding hyphens to two instances of "Composer based" in the README table of contents.

@GaryJones GaryJones requested a review from jrfnl March 29, 2020 17:21
@jrfnl jrfnl merged commit af4a0a7 into PHPCSStandards:develop Mar 29, 2020
@jrfnl
Copy link
Member

jrfnl commented Mar 29, 2020

Thank you so much for this @GaryJones ! Please have this badge for being the first (external) contributor to this repo: 🛡️

@jrfnl jrfnl modified the milestones: 1.0.0, 1.0.0-alpha3 May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants