Implemented functions for instrument and event-instrument api #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add_instrument_api # Conflicts: # R/redcap-event-instruments.R
|
This is great, @vcastro. I'm almost done reviewing it. Can you please tell me your ORCID number? I'd like to add it in the description file. |
|
@vcastro, thanks for putting so much effort into your new code, and making it consistent with the rest of the package & tests. This will be easy to maintain in the future. I made a few minor tweaks --will you please make sure I'm consistent with your intent? Also, please send me your email address if you'd like it included in the package description file. |
don't know why I used equals here
|
Hi Will, Great - thanks for reviewing the PR and including it in the package! My email is [email protected] and my ORCID id is: 0000-0001-7390-6354. Thanks, |
wibeasley
added a commit
that referenced
this pull request
Feb 24, 2022
wibeasley
added a commit
that referenced
this pull request
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Will,
Really excellent package - thanks for making it!
I've implemented functions for the REDCap instruments and formEventMapping (event-instruments) API endpoints that I needed for a project. I've also included tests for both. Please have a look.
Thanks,
Victor