Skip to content

Conversation

@kd0oss
Copy link
Contributor

@kd0oss kd0oss commented Apr 1, 2025

Added M17 Metatext.
Fixed Module17 HMI button lockup.

@silseva
Copy link
Collaborator

silseva commented Aug 19, 2025

Hi Rick,
do you mind splitting each contribution into separate pull requests?
I see three blocks which can become three different PRs:

  • GPS metadata
  • support for packet mode
  • GUI for SMS

Having separate pull requests will help me reviewing the code speeding up the merge process. Please make a commit for each logical change in the code and in the commit messages use a format like “make xyzzy do frotz” or “changed xyzzy to do frotz”. You can get an idea of the commit message format also by taking a look at the history of the main branch.

Sorry for being a bit picky on this, but having a uniform code style and commit message style helps lowering the entry barrier for everyone willing to contribute.

Thank you,
Silvano IU2KWO

turnrye added a commit to turnrye/OpenRTX that referenced this pull request Sep 15, 2025
…mode

This commit contains the original work on supporting sending and receiving metadata, both text and gnss, for the M17 mode. This was included as part of a larger PR OpenRTX#314 which the lead requested be split up, with the first PR focusing on this feature alone.

This change was created by taking 23d8034 and picking over only files, and in some case sections of files, in order for the metadata features to function. It has generally been tested to ensure that the picking was done properly, but further verification of the intended functionality has not taken place as part of this commit.

Co-authored-by: Rick <[email protected]>
Co-authored-by: Jim Ancona <[email protected]>
Co-authored-by: Wojciech Kaczmarski <[email protected]>
@turnrye turnrye mentioned this pull request Sep 15, 2025
sp6hfe and others added 4 commits September 16, 2025 16:47
Corrected callsign encoding to handle ALL/Broadcast addressing properly.
Commented out include line used for debugging.
@turnrye turnrye mentioned this pull request Sep 22, 2025
@turnrye turnrye mentioned this pull request Oct 1, 2025
@turnrye turnrye mentioned this pull request Oct 10, 2025
@turnrye turnrye mentioned this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants