Skip to content

Update test_flops_geom_builder.py #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2024
Merged

Update test_flops_geom_builder.py #613

merged 2 commits into from
Dec 4, 2024

Conversation

crecine
Copy link
Contributor

@crecine crecine commented Nov 20, 2024

Summary

hybrid geom builder should have use_both_geometries = True

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

@crecine
Update test_flops_geom_builder.py
557d45c 
hybrid geom builder should have use_both_geometries = True
@crecine
Update test_gasp_geom_builder.py
a4c07fb
@xjjiang
Copy link
Contributor

xjjiang commented Nov 28, 2024

There are many flags in geometry builders (e.g. Aircraft.Wing.HAS_FOLD, Aircraft.Wing.HAS_STRUT). Ideally, we should test all the combinations. But we will skip them for now.

@jkirk5 jkirk5 added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 9e63e60 Dec 4, 2024
6 checks passed
@crecine crecine deleted the crecine-patch-1 branch December 9, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kenneth-T-Moore Kenneth-T-Moore Kenneth-T-Moore approved these changes

@jkirk5 jkirk5 jkirk5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crecine @xjjiang @Kenneth-T-Moore @jkirk5