[wmr] Fix type of wmr_config_header field #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calibration header contains a 16 bit version field, which we are incorrectly parsing as part of the json_start field. Presumably this has gone unnoticed because the header version field is always set to 0 in practice. Change type of json_start field from uint32_t to uint16_t, and insert a new field uint16_t header_version.
|
Question, if the value is always 0, why do you know for sure this is a config header field, do you have any example logs that show differences between headsets or similar to this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calibration header contains a 16 bit version field, which we are
incorrectly parsing as part of the json_start field. Presumably this has
gone unnoticed because the header version field is always set to 0 in
practice.
Change type of json_start field from uint32_t to uint16_t, and insert a
new field uint16_t header_version.