Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed small grammar error in README.md #4731

Merged
merged 1 commit into from
Feb 18, 2023
Merged

fixed small grammar error in README.md #4731

merged 1 commit into from
Feb 18, 2023

Conversation

Patrick-Ames
Copy link
Contributor

@Patrick-Ames Patrick-Ames commented Feb 12, 2023 •
edited
Loading

"It also serves as central knowledge base" > "It also serves as a central knowledge base"

  • Your changes are not possible to do through a plugin and relevant
    to a large audience (ideally all users of OctoPrint)
  • If your changes are large or otherwise disruptive: You have
    made sure your changes don't interfere with current development by
    talking it through with the maintainers, e.g. through a
    Brainstorming ticket
  • Your PR targets OctoPrint's devel branch if it's a completely
    new feature, or maintenance if it's a bug fix or improvement of
    existing functionality for the current stable version (no PRs
    against master or anything else please)
  • Your PR was opened from a custom branch on your repository
    (no PRs from your version of master, maintenance, or devel
    please), e.g. dev/my_new_feature or fix/my_bugfix
  • Your PR only contains relevant changes: no unrelated files,
    no dead code, ideally only one commit - rebase and squash your PR
    if necessary!
  • Your changes follow the existing coding style
  • If your changes include style sheets: You have modified the
    .less source files, not the .css files (those are generated
    with lessc)
  • You have tested your changes (please state how!) - ideally you
    have added unit tests
  • You have run the existing unit tests against your changes and
    nothing broke
  • You have added yourself to the AUTHORS.md file :)

What does this PR do and why is it necessary?

How was it tested? How can it be tested by the reviewer?

Any background context you want to provide?

What are the relevant tickets if any?

Screenshots (if appropriate)

Further notes

@Patrick-Ames
fixed small grammar error in README.md
9d9d48e 
"It also serves as central knowledge base" > "It also serves as a central knowledge base"
@github-actions github-actions bot added docs Related to documentation targets master The PR targets the master branch approved Issue has been approved by the bot or manually for further processing labels Feb 12, 2023
@cp2004 cp2004 merged commit b151152 into OctoPrint:master Feb 18, 2023
@Patrick-Ames Patrick-Ames deleted the patch-1 branch February 18, 2023 19:38
AdamantLife added a commit to AdamantLife/OctoPrint-PrusaMK3S that referenced this pull request Mar 9, 2023
@AdamantLife
Squashed commit of the following:
2a8117b 
commit 0fcb15d
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Mar 7 10:50:21 2023 +0100

    Bump actions/upload-artifact from 1 to 3 (OctoPrint#4742)

    Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 1 to 3.
    - [Release notes](https://github.com/actions/upload-artifact/releases)
    - [Commits](actions/upload-artifact@v1...v3)

    ---
    updated-dependencies:
    - dependency-name: actions/upload-artifact
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 8e4c1f5
Merge: 7489b3c d813a0c
Author: Gina Häußge <[email protected]>
Date:   Thu Mar 2 16:07:26 2023 +0100

    Merge branch 'staging/bugfix'

commit d813a0c
Author: Charlie Powell <[email protected]>
Date:   Mon May 30 10:04:51 2022 +0100

    :arrow_up: Bump wrapt to fix Python 3.11 compatibility (OctoPrint#4530)

    Fully tested on 3.7, 3.10 and 3.11 - any issues that did exist appear to have been resolved.

commit 7489b3c
Merge: fcb9eae 6e009d2
Author: Gina Häußge <[email protected]>
Date:   Thu Mar 2 15:58:56 2023 +0100

    Merge branch 'staging/bugfix'

commit 6e009d2
Author: Gina Häußge <[email protected]>
Date:   Thu Mar 2 15:51:32 2023 +0100

    🔖 Preparing release of 1.8.7

commit 59054cc
Author: Gina Häußge <[email protected]>
Date:   Thu Mar 2 15:34:39 2023 +0100

    🥅 Don't send `None` to `Locale.parse`

    The latest version of Babel no longer supports this
    but raises an error, which in turn leads to a
    500 Server Error response here.

    To fix this, we set a default for best_match.

    Closes OctoPrint#4744

commit fcb9eae
Author: Nick Mattis <[email protected]>
Date:   Mon Feb 20 16:36:28 2023 -0500

    :pencil2: Minor updates to plugin getting started tutorial docs (OctoPrint#4736)

    * some minor updates to plugin getting started tutorial docs

    * fix helloworld to stay camelcase

commit b151152
Author: Patrick J. Ames <[email protected]>
Date:   Sat Feb 18 09:25:21 2023 -0500

    :pencil2: Fix small grammar error in README.md (OctoPrint#4731)

    "It also serves as central knowledge base" > "It also serves as a central knowledge base"

commit a1d95dd
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Feb 10 13:08:19 2023 +0100

    Bump dessant/lock-threads from 2 to 4 (OctoPrint#4726)

    * Bump dessant/lock-threads from 2 to 4

    Bumps [dessant/lock-threads](https://github.com/dessant/lock-threads) from 2 to 4.
    - [Release notes](https://github.com/dessant/lock-threads/releases)
    - [Changelog](https://github.com/dessant/lock-threads/blob/master/CHANGELOG.md)
    - [Commits](dessant/lock-threads@v2...v4)

    ---
    updated-dependencies:
    - dependency-name: dessant/lock-threads
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

    * 👷‍♂️ Adjust input parameters

    Names changed in v3

    ---------

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Gina Häußge <[email protected]>

commit c01216c
Author: Gina Häußge <[email protected]>
Date:   Fri Feb 10 13:03:10 2023 +0100

    👷‍♂️ Only trigger docs build on specific branches

    master, maintenance and devel only for now

commit a47b518
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Feb 9 16:50:08 2023 +0000

    Bump robotology/gh-action-nightly-merge from 1.3.3 to 1.4.0

    Bumps [robotology/gh-action-nightly-merge](https://github.com/robotology/gh-action-nightly-merge) from 1.3.3 to 1.4.0.
    - [Release notes](https://github.com/robotology/gh-action-nightly-merge/releases)
    - [Commits](robotology/gh-action-nightly-merge@v1.3.3...v1.4.0)

    ---
    updated-dependencies:
    - dependency-name: robotology/gh-action-nightly-merge
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

commit 40d71f1
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Feb 9 16:50:00 2023 +0000

    Bump peter-evans/repository-dispatch from 1 to 2

    Bumps [peter-evans/repository-dispatch](https://github.com/peter-evans/repository-dispatch) from 1 to 2.
    - [Release notes](https://github.com/peter-evans/repository-dispatch/releases)
    - [Commits](peter-evans/repository-dispatch@v1...v2)

    ---
    updated-dependencies:
    - dependency-name: peter-evans/repository-dispatch
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

commit 3088c3b
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Feb 9 18:00:54 2023 +0100

    Bump actions/labeler from 3 to 4 (OctoPrint#4727)

    Bumps [actions/labeler](https://github.com/actions/labeler) from 3 to 4.
    - [Release notes](https://github.com/actions/labeler/releases)
    - [Commits](actions/labeler@v3...v4)

    ---
    updated-dependencies:
    - dependency-name: actions/labeler
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 135249c
Author: Gina Häußge <[email protected]>
Date:   Thu Feb 9 17:25:55 2023 +0100

    👷 Enable Dependabot for GitHub Actions

commit 814c3a1
Author: Gina Häußge <[email protected]>
Date:   Wed Feb 8 16:20:42 2023 +0100

    👷 Migrate from set-output got $GITHUB_OUTPUT

commit 68191cf
Author: Gina Häußge <[email protected]>
Date:   Wed Jan 18 17:38:26 2023 +0100

    💚 HTTP has \r\n line endings

    So we need to strip \r, \n already gets taken care of
    by the whole pipe. Also limit to first location header
    just in case.

commit c5b56ae
Author: Gina Häußge <[email protected]>
Date:   Wed Jan 18 17:15:30 2023 +0100

    👷 Get rid of newline in version

commit cc47b41
Author: Gina Häußge <[email protected]>
Date:   Wed Jan 18 17:06:43 2023 +0100

    👷 Fetch latest release without any action

    bash, curl, awk ftw

commit 397de4e
Author: Gina Häußge <[email protected]>
Date:   Wed Jan 18 16:47:37 2023 +0100

    👷 Use original get-latest-release action

commit 9179545
Author: Gina Häußge <[email protected]>
Date:   Mon Dec 19 14:33:41 2022 +0100

    📝 Get rid of Twitter link, fix build status badge

commit 7659c81
Author: Gina Häußge <[email protected]>
Date:   Wed Nov 16 14:46:25 2022 +0100

    🚨 Fix pre-commit's flake8 location

commit 7d336bd
Author: Gina Häußge <[email protected]>
Date:   Sat Nov 12 14:53:19 2022 +0100

    📝 Thou shall test in safe mode before opening bug reports

commit 588a1c4
Author: Gina Häußge <[email protected]>
Date:   Tue Oct 18 11:44:07 2022 +0200

    🔖 staging/bugfix is now 1.8.7.dev
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cp2004 cp2004 cp2004 approved these changes

Assignees
No one assigned
Labels
approved Issue has been approved by the bot or manually for further processing docs Related to documentation targets master The PR targets the master branch
Projects
OctoPrint Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Patrick-Ames @cp2004