Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefetch urls in background and insert "real" anchor links #543

Merged
merged 18 commits into from
Mar 11, 2019
Merged

Prefetch urls in background and insert "real" anchor links #543

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
52e8529
Remove lazy loader for relative files
Feb 2, 2019
1c34ecf
Add setting to enable support for private repositories
Feb 2, 2019
6b39f79
Insert real href tag
Feb 2, 2019
5f2cdff
Add token field to settings page
Feb 3, 2019
3219289
Add octolinker api helper
Feb 8, 2019
c07da33
Align format with new octolinker api
Feb 8, 2019
360c8e0
Use ZEIT now deployment
Feb 15, 2019
f6fc910
Split head from base sha in url
Feb 15, 2019
d69c173
Resolve urls with either the github or octolinker API
Feb 15, 2019
ed3f5de
Update E2E test to work with href attribute
Feb 16, 2019
06b00b1
Correct grammar
josephfrazier Mar 1, 2019
b4e7ec2
Implement simple GitHub search
Mar 1, 2019
8d73f6b
Remove option to toggle line indicator
Mar 7, 2019
b086f21
Open settings dialog rather than being a new tab
Mar 7, 2019
c7c2d66
Fix GitHub API call in Firefox
Mar 7, 2019
4d0837b
Simplify loader
Mar 10, 2019
2f91910
Add trusted url resolver to reduce load on octolinker api
Mar 10, 2019
bb40146
Fix tests
Mar 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Split head from base sha in url 
In some cases the file path in PR comment contains head and a base sha like https://github.com/user/repo/pull/123/files/f18370bde83d7f1ced7acf5af54a21d2e53912ff..637d21dd86c8f50e9100b8da656e43cadcccde4d#diff-fd9ad2ea8184b3a5e7d76f54e87ae438
  • Loading branch information
Stefan Buck committed Feb 15, 2019
commit f6fc910d8ec9e0315a3500c7f0eae848cfed305c
3 changes: 2 additions & 1 deletion packages/blob-reader/helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ function mergeRepoAndFilePath(repoPath, filePath) {
const repoUrl = repoPath
.trim()
.split('#')[0]
.replace(/pull\/[0-9]+\/files/, 'blob');
.replace(/pull\/[0-9]+\/files/, 'blob')
.split('..')[0];

return `${repoUrl}/${filePath.trim()}`;
}
Expand Down