Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rate limit notification component #541

Merged
merged 5 commits into from
Feb 1, 2019

Conversation

stefanbuck
Copy link
Member

This PR is in preparation for another PR which will replace the try-load strategy to resolve relate files with an actual GitHub API call. This API endpoint returns a tree of the repositories file structure which we can use to resolve relative links much faster https://developer.github.com/v3/git/trees/. However, this PR is just about adding a rate limit notification component to inform the user about various states see messages.js

Copy link
Member

@josephfrazier josephfrazier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this myself, but I made some spelling/grammar suggestions

packages/ratelimit-notification/messages.js Outdated Show resolved Hide resolved
packages/ratelimit-notification/messages.js Outdated Show resolved Hide resolved
@stefanbuck stefanbuck merged commit 9ba8c38 into OctoLinker:master Feb 1, 2019
@stefanbuck stefanbuck deleted the rate-limit-notification branch February 1, 2019 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants