Does not bail out when capture group is empty #540
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for #539.
OctoLinker stopped working, because the key
decompress-response
was defined with a boolean value instead of a string.This was causing the following runtime error
TypeError: Cannot read property 'length' of undefined
.OctoLinker/packages/helper-insert-link/index.js
Line 32 in cbbb95b
I fixed this issue in two places. First, the npm plugin returns early if the given value is not from type string. Second, if a capture group is empty (which should be never the case), the current node will be returned without adding a link.