Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to not duplicate package send to live-resolver #531

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Fix to not duplicate package send to live-resolver #531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix to not duplicate package send to live-resolver 
I did a stupid mistake in the previous implementation. For every URL within a resolve item it was duplicating the resolves items wich caused N+1 requests for every package. Luckily it was just sending two request for each package
  • Loading branch information
Stefan Buck committed Dec 18, 2018
commit bfade75756edbcd7ac262d66fd4d6ccaf47e58b0
12 changes: 6 additions & 6 deletions packages/core/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,15 @@ async function runLiveQuery(matches) {
createStore(json, payload);
}

function matchContainsOnlyRegistyMatches(match) {
return match.urls.every(url => url.type === 'registry');
}

function filterLiveResolver(matches) {
return matches.reduce((memo, match) => {
match.urls.forEach(url => {
if (url.type !== 'registry') {
return;
}

if (matchContainsOnlyRegistyMatches(match)) {
memo.push(match);
});
}

return memo;
}, []);
Expand Down