Refine settings page #522
Merged
Refine settings page #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanbuck
commented
Nov 13, 2018
| @@ -22,6 +22,7 @@ | |||
| }, | |||
| "options_ui": { | |||
| "page": "options.html", | |||
| "open_in_tab": true, | |||
There was a problem hiding this comment.
This value is false by default. If set to true, the options page will open in a normal browser tab, rather than being integrated into the browser's add-ons manager.
This change is needed as a work around for this bug, where the dialog is jumping up and down https://bugs.chromium.org/p/chromium/issues/detail?id=904942#c1
stefanbuck
force-pushed
the
settings-improvments
branch
from
9f5fa9e to
8d856e2
Compare
stefanbuck
force-pushed
the
settings-improvments
branch
from
8d856e2 to
ad8233d
Compare
|
@josephfrazier I guess you're happy with me merging this. |
Merged
|
This looks fine to me! Sorry for the huge delay, I haven't had a lot of time for open-source work recently. |
|
Nothing to worry 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request improves the settings page by providing feedback if the entered token is valid or not.