Little refactoring to avoid circular execution when listing for dom mutations #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephfrazier
approved these changes
Sep 14, 2018
Member
Author
|
Thanks for the instant review @josephfrazier 😉 |
Member
|
happy to help! This was a small change, so it was easy to glance at. I didn't test it myself, but I assume you did |
Member
Author
|
Sure I did and it's also covered by E2E tests 😃 |
Contributor
|
Nice! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the following PR microdevs/missy#39 causes the browser hang when trying to add a inline comment. I tested the same functionally on a few other PRs and it worked fine for all of them. However, I was able to narrow it down to the
MutationObserverwhich is called over and over again. I have no idea what is different there, but I decided to rewrite the related code to only spy for dom mutations when expanding the blob.