Handle undefined results in the match array #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanbuck
commented
Feb 7, 2018
| @@ -18,7 +18,12 @@ function initialize(self) { | |||
| } | |||
|
|
|||
| function insertDataAttr(matches) { | |||
| matches.forEach(({ data, link }) => { | |||
| matches.forEach(item => { | |||
There was a problem hiding this comment.
Another solutions would be to strip out all undefindes in the first place, although this would require an additional loop over matches. Anyway, at the end it really doesn't matter IMO
josephfrazier
approved these changes
Feb 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #443. This was caused by combination, where the composer plugin returns
undefinedif the json key isphpand a not solidforEachloop in the octolinker core.