Add Lerna #433
Merged
Add Lerna #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanbuck
force-pushed
the
lerna
branch
3 times, most recently
from
1bbb61f to
bbfdc2f
Compare
added 13 commits
January 13, 2018 22:43
Closed
josephfrazier
approved these changes
Jan 14, 2018
There was a problem hiding this comment.
This looks good to me, I was able to build/run the extension! @stefanbuck, I'll let you decide when to merge, in case you think of anything else. Also, I assume it might be better to squash/merge instead of rebase/merge, since there seem to be some intermediate commits where things are broken (it's nice seeing the separate commits during this PR review process, however!).
|
Thanks for reviewing. I've created the commits with the review in mind. Sure I'll squash them as always ... now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #432 this PR adds lerna. A tool to manage multiple packages in the same repo. I moved the
libfolder into a new package calledcorealong with all dependencies. Also I added a few morepackage.jsonfiles and cleaned up the dependencies in the root.