Handle leading whitespace in diff line #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephfrazier
approved these changes
Dec 7, 2017
stefanbuck
commented
Dec 7, 2017
| @@ -461,7 +461,7 @@ function fixturesIterator(fixturesList, next) { | |||
|
|
|||
| function addModifiedLines(valid) { | |||
| const [text, expected] = valid[0]; | |||
| const diffLines = [[`-${text}`, expected], [`+${text}`, expected]]; | |||
| const diffLines = [[` -${text}`, expected], [` +${text}`, expected]]; | |||
There was a problem hiding this comment.
@josephfrazier this small change is testing the new behaviour
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#409 introduced a bug that stopped OctoLinker from inserting links. On GitHub a diff line starts with a whitespace character if the line is not modified which the RegeEx doesn't take into account.
Before
After