Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm install on Windows #244

Merged
merged 3 commits into from
Dec 31, 2016
Merged

Fix npm install on Windows #244

merged 3 commits into from
Dec 31, 2016

Conversation

morganj
Copy link
Contributor

@morganj morganj commented Dec 30, 2016

I was getting the following errors on npm install:

npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "i"
npm ERR! node v6.9.2
npm ERR! npm  v3.10.9
npm ERR! code EBADPLATFORM

npm ERR! notsup Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm ERR! notsup Valid OS:    darwin
npm ERR! notsup Valid Arch:  any
npm ERR! notsup Actual OS:   win32
npm ERR! notsup Actual Arch: x64

Resolved by adding fsevents to optionalDependencies.

Then the symlink for pre-commit failed:

> [email protected] postinstall C:\browser-extension
> ln -sf ./scripts/hooks/pre-commit .git/hooks/pre-commit

ln: failed to create symbolic link '.git/hooks/pre-commit': No such file or directory

Resolved by managing githooks with husky.

josephfrazier
josephfrazier approved these changes Dec 30, 2016
View reviewed changes
Copy link
Member

@josephfrazier josephfrazier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, @morganj! This LGTM, but I'll wait for @stefanbuck to merge.

In the meantime, could you add a commit that removes --no-shrinkwrap --ignore-scripts from appveyor.yml? If I understand the changes correctly, those flags should no longer be needed. See 2cd1192 (#189) for more details. Thanks!

stefanbuck
stefanbuck approved these changes Dec 31, 2016
View reviewed changes
Copy link
Member

@stefanbuck stefanbuck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stefanbuck stefanbuck merged commit 0397d71 into OctoLinker:master Dec 31, 2016
@stefanbuck
Copy link
Member

Thanks @morganj 👍

@josephfrazier josephfrazier mentioned this pull request Dec 31, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephfrazier josephfrazier josephfrazier approved these changes

@stefanbuck stefanbuck stefanbuck approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morganj @stefanbuck @josephfrazier