Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve links in code blocks #224

Merged
merged 3 commits into from
Dec 8, 2016

Conversation

stefanbuck
Copy link
Member

@stefanbuck stefanbuck commented Dec 7, 2016

Finally I managed to resolve links within discussion and other none-code documents like markdown files. By the nature of those files it will not work for relative paths. Also it doesn't work for JSON blocks. Anyway, it's quite handy and provides more value to the user.

Works in discussions

screen shot 2016-12-08 at 00 47 58

or in README files

screen shot 2016-12-08 at 00 46 58

Dependencies

Copy link
Member

@josephfrazier josephfrazier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I'm completely on board with this, but it looks like the tests fail now that I've I merged #223 and #222. Could you take a look? I hope I didn't get the merge order wrong.

@stefanbuck
Copy link
Member Author

@josephfrazier after rebasing the branch is green now. Since you already approved it, I'll merge it by myself.

@stefanbuck stefanbuck merged commit e3b0f7b into OctoLinker:master Dec 8, 2016
@stefanbuck stefanbuck deleted the resolve-issue-links branch December 8, 2016 19:01
@josephfrazier
Copy link
Member

Oops, I didn't consider rebasing at the time. Thanks for fixing it up 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants